Bug 80482 – Rename notification properties and functions

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Jon Lee]

Proposal:
1. replaceId -> id
2. cancel -> close

<rdar://problem/10912432>

[Jon Lee]

Created attachment 130724 [details]
WIP

[Jon Lee]

Created attachment 130729 [details]
WIP #2

[Kentaro Hara]

(In reply to comment #0)
> Proposal:
> 1. replaceId -> id
> 2. cancel -> close

Is this speced?

It appears that the spec uses replaceId and cancel():

http://www.w3.org/TR/notifications/

[Early Warning System Bot]

Comment on attachment 130729 [details]
WIP #2

Attachment 130729 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11865047

[WebKit Review Bot]

Comment on attachment 130729 [details]
WIP #2

Attachment 130729 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11867056

[Jon Lee]

(In reply to comment #3)
> (In reply to comment #0)
> > Proposal:
> > 1. replaceId -> id
> > 2. cancel -> close
> 
> Is this speced?
> 
> It appears that the spec uses replaceId and cancel():
> 
> http://www.w3.org/TR/notifications/

No this is not agreed upon in the spec yet. It's still under discussion. But I decided to post the patch up anyway to get the EWS results. Anyway, I don't intend on submitting this until there's been discussion and agreement in the WG.

[Kentaro Hara]

Comment on attachment 130729 [details]
WIP #2

> No this is not agreed upon in the spec yet. It's still under discussion. But I decided to post the patch up anyway to get the EWS results. Anyway, I don't intend on submitting this until there's been discussion and agreement in the WG.

OK, let me invalidate r?.

[Early Warning System Bot]

Comment on attachment 130729 [details]
WIP #2

Attachment 130729 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/11865179

[Jon Lee]

Created attachment 130900 [details]
Patch

[Kentaro Hara]

Comment on attachment 130900 [details]
Patch

r- due to no consensus on the spec.

You can upload the patch with the "--no-review" option, if you do not intend to have the patch be reviewed. If you want to see the ews-bot results, you can just click "Submit for EWS analysis".

[Jon Lee]

Created attachment 131792 [details]
Patch

[Jon Lee]

Created attachment 131793 [details]
Patch

[Jon Lee]

Created attachment 135015 [details]
Patch

[Jon Lee]

Comment on attachment 135015 [details]
Patch

Changes based on discussions in the WG:

http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

[Kentaro Hara]

The patch looks OK.

(In reply to comment #14)
> http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
> http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

Is the spec going to be updated soon (i.e. did anyone start the work)? If so, let me r+ it. I am a bit afraid that the WebKit implementation becomes inconsistent with the spec in case where no one is interested in updating the spec.

[Jon Lee]

(In reply to comment #15)
> The patch looks OK.
> 
> (In reply to comment #14)
> > http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
> > http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html
> 
> Is the spec going to be updated soon (i.e. did anyone start the work)? If so, let me r+ it. I am a bit afraid that the WebKit implementation becomes inconsistent with the spec in case where no one is interested in updating the spec.

To my knowledge, John is current editor of the spec, and I know he intends on updating the spec based on all the discussions the WG has had.

[Kentaro Hara]

Comment on attachment 135015 [details]
Patch

OK!

[Jon Lee]

Committed r112821: <http://trac.webkit.org/changeset/112821>