Bug 80492 – [Qt] Fix the SH4 build after r109834

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/109834 broke the ARM/MIPS/SH4
build because their macroassemblers are incomplete.

It is a P1/blocker bug, because now nobody can build trunk WebKit for Qt-ARM (eg. for N9)

[Csaba Osztrogonác]

Missing functions from MacroAssemblerARM:
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerARM::ResultCondition, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)'
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerARM::ResultCondition, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)'


Missing functions from MacroAssemblerMIPS:
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerMIPS::ResultCondition, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&)'
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerMIPS::ResultCondition, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&)'

Missing functions from MacroAssemblerSH4:
- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerSH4::ResultCondition, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&)'

- ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerSH4::ResultCondition, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&)'

[Oliver Hunt]

Sigh, I'll hit it with a stick in the morning.

[Csaba Osztrogonác]

[e-mail], [e-mail]

[Csaba Osztrogonác]

(In reply to comment #3)
> [e-mail], [e-mail]

Oooop, copy/paste error. :) I cc-ed MIPS and SH4 guys too.

[Simon Hausmann]

ARM fix landed in http://trac.webkit.org/changeset/110044

[Csaba Osztrogonác]

cc Holger too, he might be interested in fixing MIPS and SH4 platforms.

[Chao-ying Fu]

Created attachment 130734 [details]
Add MIPS branch(Add,Sub)32 functions

Hi,

  Here is a MIPS patch.  Thanks!

Regards,
Chao-ying

[WebKit Review Bot]

Comment on attachment 130734 [details]
Add MIPS branch(Add,Sub)32 functions

Clearing flags on attachment: 130734

Committed r110147: <http://trac.webkit.org/changeset/110147>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen to fix SH4 build too.

[thouraya]

Created attachment 130822 [details]
fix for sh4 platform

[Zoltan Herczeg]

Comment on attachment 130822 [details]
fix for sh4 platform

r=me

[WebKit Review Bot]

Comment on attachment 130822 [details]
fix for sh4 platform

Clearing flags on attachment: 130822

Committed r110289: <http://trac.webkit.org/changeset/110289>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.