RESOLVED FIXED 80354
At basic support for constant blinding to the JIT 
https://bugs.webkit.org/show_bug.cgi?id=80354
Summary At basic support for constant blinding to the JIT
Oliver Hunt
Reported 2012-03-05 17:01:54 PST
At basic support for constant blinding to the JIT
Attachments
Patch (71.81 KB, patch)
2012-03-05 17:28 PST, Oliver Hunt 		fpizlo: review+
DetailsFormatted DiffDiff
the patch (20.56 KB, patch)
2012-03-05 22:19 PST, Filip Pizlo 		fpizlo: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-03-05 17:28:38 PST
Created attachment 130245 [details] Patch
Oliver Hunt
Comment 2 2012-03-05 18:40:26 PST
Committed r109834: <http://trac.webkit.org/changeset/109834>
Oliver Hunt
Comment 3 2012-03-05 20:39:10 PST
I have had a significant insight into how it is we break Qt ARMv7 so frequently (this patch broke it). The Qt ARMv7 bot is misconfigured and is using the ARM backend instead of ARMv7.
Filip Pizlo
Comment 4 2012-03-05 22:19:44 PST
Created attachment 130291 [details] the patch Putting up for EWS.
Oliver Hunt
Comment 5 2012-03-05 22:22:39 PST
(In reply to comment #4) > Created an attachment (id=130291) [details] > the patch > > Putting up for EWS. wrong bug :D
Filip Pizlo
Comment 6 2012-03-05 22:30:10 PST
(In reply to comment #5) > (In reply to comment #4) > > Created an attachment (id=130291) [details] [details] > > the patch > > > > Putting up for EWS. > > wrong bug :D Oh oops.
Filip Pizlo
Comment 7 2012-03-05 22:30:29 PST
Comment on attachment 130291 [details] the patch This wasn't supposed to be uploaded to this bug.
Martin Jansa
Comment 8 2012-04-29 14:07:43 PDT
This seems to broke build for e.g. armv4t, will try to rebuild for armv7a and then open separate bug report for that if needed /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h: In member function 'void JSC::MacroAssembler::or32(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)': /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:813:49: error: no matching function for call to 'JSC::MacroAssembler::or32(const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::TrustedImm32&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)' /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:813:49: note: candidates are: /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:805:10: note: void JSC::MacroAssembler::or32(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID) /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:805:10: note: no known conversion for argument 1 from 'const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::TrustedImm32' to 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32' /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:816:10: note: void JSC::MacroAssembler::or32(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID) /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:816:10: note: candidate expects 2 arguments, 3 provided In file included from /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/webkit-efl/webkit-efl-1.7.5+svnr115597-r0/src/Source/JavaScriptCore/assembler/MacroAssembler.h:36:0,
Note You need to log in before you can comment on or make changes to this bug.