Bug 80257 - Lifecycle of InternalSettings should be simplified.
Summary: Lifecycle of InternalSettings should be simplified.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
Depends on:
Blocks: 79935
  Show dependency treegraph
Reported: 2012-03-05 02:10 PST by Hajime Morrita
Modified: 2012-03-05 16:47 PST (History)
0 users

See Also:

Patch (5.78 KB, patch)
2012-03-05 16:35 PST, Hajime Morrita
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-03-05 02:10:36 PST
InternalSettings::create() is simply crazy. We need to simplify it before it becomes worse.
Comment 1 Hajime Morrita 2012-03-05 16:35:24 PST
Created attachment 130229 [details]
Comment 2 Ryosuke Niwa 2012-03-05 16:40:46 PST
Comment on attachment 130229 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=130229&action=review


> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=80257
> +        Lifecycle of InternalSettings should be simplified.

The order is wrong :(

> Source/WebCore/testing/InternalSettings.cpp:94
> +    , m_passwordEchoDurationInSecondsBackup(settings()->passwordEchoDurationInSeconds())
> +    , m_passwordEchoEnabledBackup(settings()->passwordEchoEnabled())

It's better to call these two variables m_originalPasswordEchoDurationInSeconds and m_originalPasswordEchoEnabled to be consistent with similar variables in WebKit.
Comment 3 Hajime Morrita 2012-03-05 16:47:44 PST
Committed r109817: <http://trac.webkit.org/changeset/109817>