We should change clients of RetainPtr to use the adoptCF function instead of the adoptCF constructor argument. Then we should get rid of the AdoptCF constructor or make it private.
This is mostly done.
Created attachment 203014 [details] Patch
*** Bug 80223 has been marked as a duplicate of this bug. ***
This will break iOS so I can’t land it until I do some work on the internal code there.
Created attachment 230797 [details] Patch
Attachment 230797 [details] did not pass style-queue: ERROR: Source/WTF/wtf/RetainPtr.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/RetainPtr.h:62: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/RetainPtr.h:107: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r168348: <http://trac.webkit.org/changeset/168348>