Bug 80011 - ES5.1- prohibits Function.caller from [[Get]]ting a strict caller
Summary: ES5.1- prohibits Function.caller from [[Get]]ting a strict caller
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
: 45480 (view as bug list)
Depends on:
Reported: 2012-03-01 00:06 PST by Gavin Barraclough
Modified: 2012-03-07 17:20 PST (History)
4 users (show)

See Also:

Fix (16.22 KB, patch)
2012-03-01 00:16 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-03-01 00:06:30 PST
Also, fix getting the caller from within a bound function, for within a getter, or setter (make our implementation match other browsers).
Comment 1 Gavin Barraclough 2012-03-01 00:16:53 PST
Created attachment 129651 [details]
Comment 2 WebKit Review Bot 2012-03-01 00:19:16 PST
Attachment 129651 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/interpreter/Interpreter.cpp:51:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-03-01 03:11:00 PST
Comment on attachment 129651 [details]

Attachment 129651 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11770384

New failing tests:
Comment 4 Gavin Barraclough 2012-03-01 16:13:30 PST
Fixed in r109461
Comment 5 Csaba Osztrogonác 2012-03-02 05:37:11 PST
Reopen, because it broke fast/js/function-dot-arguments-and-caller.html. (At least on SL and on Qt.)

--- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/fast/js/function-dot-arguments-and-caller-expected.txt 
+++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/fast/js/function-dot-arguments-and-caller-actual.txt 
@@ -2,5 +2,5 @@
 If the test passes, you'll see a series of PASS messages below.
Comment 6 Csaba Osztrogonác 2012-03-02 06:33:16 PST
I skipped it on Qt to make bot happier - http://trac.webkit.org/changeset/109571/trunk/LayoutTests/platform/qt/Skipped

Please unskip it with the proper fix. Thanks.
Comment 7 Gavin Barraclough 2012-03-02 17:52:52 PST
Fixed in r109644.
Comment 8 Gavin Barraclough 2012-03-07 17:20:28 PST
*** Bug 45480 has been marked as a duplicate of this bug. ***