Bug 79734 - :empty still applies to elements made non-empty via page dynamics
Summary: :empty still applies to elements made non-empty via page dynamics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
: 75294 79730 (view as bug list)
Depends on: 26570
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-27 19:05 PST by noel gordon
Modified: 2012-04-26 18:48 PDT (History)
10 users (show)

See Also:


Attachments
test case (709 bytes, text/html)
2012-02-27 19:06 PST, noel gordon
no flags Details
ProposedPatch (3.85 KB, patch)
2012-02-29 13:04 PST, Joe Thomas
no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2012-03-01 20:44 PST, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-02-27 19:05:14 PST
Create empty elements with :empty class styling.  These elements don't display as expected.  Change the content of the elements using js to make them non-empty.  The elements still don't display and they should.

Reproduction Steps:
  1) Open test case, two green boxes are shown.
  2) Click on the page.

Expected result:
  Three green boxes should appear.

Actual result:
  The third green box does not appear.
Comment 1 noel gordon 2012-02-27 19:06:28 PST
Created attachment 129164 [details]
test case
Comment 2 noel gordon 2012-02-27 19:08:50 PST
*** Bug 79730 has been marked as a duplicate of this bug. ***
Comment 3 noel gordon 2012-02-27 19:23:29 PST
Other browsers tested:

   Safari 5.1.2 (6534.52.7, 535+) : FAIL
   Chrome 19.0.1049.3 dev Mac : FAIL
   Firefox 10.0.2 Mac :  OK
   IE9/10 Win: OK
Comment 4 Joe Thomas 2012-02-29 13:04:05 PST
Created attachment 129498 [details]
ProposedPatch
Comment 5 WebKit Review Bot 2012-03-01 09:53:57 PST
Comment on attachment 129498 [details]
ProposedPatch

Rejecting attachment 129498 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11770534
Comment 6 Joe Thomas 2012-03-01 10:28:14 PST
Can someone help me to land this patch? It failed at the commit-queue with false error.
Comment 7 noel gordon 2012-03-01 13:51:24 PST
Done, looks fine this time round.
Comment 8 WebKit Review Bot 2012-03-01 13:53:40 PST
Comment on attachment 129498 [details]
ProposedPatch

Clearing flags on attachment: 129498

Committed r109417: <http://trac.webkit.org/changeset/109417>
Comment 9 WebKit Review Bot 2012-03-01 13:53:47 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 noel gordon 2012-03-01 13:55:10 PST
For the record, fast/css/pseudo-empty-display-none.html tests the static :empty display:none case.
Comment 11 Joe Thomas 2012-03-01 14:06:07 PST
(In reply to comment #7)
> Done, looks fine this time round.

Thanks!
Comment 12 noel gordon 2012-03-01 20:41:34 PST
(In reply to comment #11)
> Thanks!

Thinking we should add a test for the reverse case for completeness: non-empty elements should gain :empty style if made empty by page dynamics.
Comment 13 noel gordon 2012-03-01 20:43:59 PST
Reopening to attach new patch.
Comment 14 noel gordon 2012-03-01 20:44:06 PST
Created attachment 129802 [details]
Patch
Comment 15 WebKit Review Bot 2012-03-02 18:57:46 PST
Comment on attachment 129802 [details]
Patch

Rejecting attachment 129802 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11801214
Comment 16 noel gordon 2012-03-02 19:29:44 PST
Comment on attachment 129802 [details]
Patch

Clearing flags on attachment: 129802

Committed r109651: <http://trac.webkit.org/changeset/109651>
Comment 17 noel gordon 2012-03-02 19:29:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 18 David Barr 2012-04-26 18:48:13 PDT
*** Bug 75294 has been marked as a duplicate of this bug. ***