79549 – Scoped stylesheets don't appear to work in Shadow DOM

Bug 79549 - Scoped stylesheets don't appear to work in Shadow DOM

Summary: Scoped stylesheets don't appear to work in Shadow DOM

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	DOM (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Roland Steiner

URL:	http://dglazkov.github.com/Web-Compon...
Keywords:

Depends on:
Blocks:	59827
	Show dependency tree / graph

Reported:	2012-02-24 18:57 PST by Dimitri Glazkov (Google)
Modified:	2012-03-06 02:50 PST (History)
CC List:	7 users (show)

See Also:

Attachments
work-in-progress (20.84 KB, patch) 2012-02-28 04:00 PST, Roland Steiner	no flags	Details \| Formatted Diff \| Diff
Patch (25.73 KB, patch) 2012-03-01 22:30 PST, Roland Steiner	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dimitri Glazkov (Google) 2012-02-24 18:57:02 PST

* Create a shadow DOM subtree
* Add scoped stylesheet to it
* Observe that the styles don't match anything in the shadow DOM tree.

Last checked at r108661.

For an example, see: http://dglazkov.github.com/Web-Components-Polyfill/

Comment 1 Roland Steiner 2012-02-28 02:53:09 PST

Indeed! :P   Attempting to use the host element as "anchor" for the style scope is probably a bad idea in the first place - working on a patch.

Comment 2 Roland Steiner 2012-02-28 04:00:01 PST

Created attachment 129226 [details]
work-in-progress

Comment 3 Roland Steiner 2012-03-01 22:30:50 PST

Created attachment 129821 [details]
Patch

Comment 4 WebKit Review Bot 2012-03-02 05:27:42 PST

Comment on attachment 129821 [details]
Patch

Clearing flags on attachment: 129821

Committed r109563: <http://trac.webkit.org/changeset/109563>

Comment 5 WebKit Review Bot 2012-03-02 05:27:49 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Ryosuke Niwa 2012-03-05 09:18:02 PST

It seems like this changeset caused ~25% regression on Parser/html5-full-render.html:
http://webkit-perf.appspot.com/graph.html#tests=[[3068,2001,3001]]&sel=1330690990310,1330703206709&displayrange=7&datatype=running
http://webkit-perf.appspot.com/graph.html#tests=[[3068,2001,3001],[3068,2001,173262]]&sel=1330693225546.817,1330698934586.7354&displayrange=7&datatype=running

Comment 7 Ryosuke Niwa 2012-03-05 09:25:12 PST

See https://bugs.webkit.org/show_bug.cgi?id=79963#c13 for further information.

Comment 8 Roland Steiner 2012-03-06 02:50:50 PST

found the culprit -> patch submitted in bug 80404