Bug 80404 - r109563 caused perf regression
Summary: r109563 caused perf regression
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 02:46 PST by Roland Steiner
Modified: 2012-03-06 04:43 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2012-03-06 02:49 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2012-03-06 03:19 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2012-03-06 02:46:30 PST 
The culprit is one line in CSSStyleSelector::pushParentElement(): changing from parentOrHostElement() to parentOrHostNode(), causing a 20% perf regression in Parser/html5-full-render.html.
Comment 1 Roland Steiner 2012-03-06 02:49:38 PST 
Created attachment 130346 [details]
Patch
Comment 2 Roland Steiner 2012-03-06 03:19:37 PST 
Created attachment 130348 [details]
Patch
Comment 3 WebKit Review Bot 2012-03-06 04:43:11 PST 
Comment on attachment 130348 [details]
Patch

Clearing flags on attachment: 130348

Committed r109906: <http://trac.webkit.org/changeset/109906>
Comment 4 WebKit Review Bot 2012-03-06 04:43:16 PST 
All reviewed patches have been landed.  Closing bug.