Add TaskQueue and apply it into LayerTreeHostProxy.
Both TaskQueue and MessageQueue are useful.
TaskQueue can reduces codes about boilerplate message definition.
MessageQueue can provide more functionality like remove.
LayerTreeHostProxy dose not require special funcionality of MessageQueue, so
TaskQueue can make LayerTreeHostProxy code more succinct.
Created attachment 128713 [details]
I will apply TaskQueue to RunLoop and etc.
Attachment 128713 [details] did not pass style-queue:
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 128715 [details]
Chrome defines Function<void()> to Closure, and defines Deque<Closure> to TaskQueue in message_loop.h in chromium project.
I mimic that.
I will bring some functionalities from chrome to WebKit when I need them.
I'm OK with the changes to LayerTreeHostProxy, but I don't get to review additions to WTF.
I think it is hard to persuade to patch TaskQueue.
I postpone it next.
Created attachment 128851 [details]
I focus on only LayerTreeHostProxy without unreasonable invasion to WTF.
I understand only one thread using LayerTreeHostProxy, so I do not use Mutex.
Created attachment 128853 [details]
Comment on attachment 128853 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=128853&action=review
Some touch ups and we're good.
> + It is succinct to collect tasks using Functional because of reducing codes about
> + boilerplate message definition.
Please reword changelog (just an English touch-up):
Use Functional instead of a MessageQueue for messages to the LayerTreeHostProxy renderer. This makes a lot of the broilerplate code for message-passing unnecessary, and results in a much more succinct implementation.
> + Vector<Function<void()> > m_functionQueue;
m_functionQueue -> m_renderQueue
Created attachment 128932 [details]
Thanks for kind review. :)
The commit-queue encountered the following flaky tests while processing attachment 128932 [details]:
css3/filters/effect-contrast-hw.html bug 79618 (author: firstname.lastname@example.org)
The commit-queue is continuing to process your patch.
Comment on attachment 128932 [details]
Clearing flags on attachment: 128932
Committed r108951: <http://trac.webkit.org/changeset/108951>
All reviewed patches have been landed. Closing bug.