Bug 79466 - [WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
: [WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Sergio Villar Senin
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 01:54 PST by Sergio Villar Senin
Modified: 2012-02-24 02:19 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2012-02-24 01:58 PST, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2012-02-24 01:54:33 PST
One of the changes suggested to my patch in https://bugs.webkit.org/show_bug.cgi?id=79252 was to replace an explicit cast plus a delete by a plain delete that takes a void* as argument.

The problem of that approach is that the delete frees the object's memory but does not invoke the destructor, something that is a must for us.
Comment 1 Sergio Villar Senin 2012-02-24 01:58:21 PST
Created attachment 128690 [details]
Patch
Comment 2 Sergio Villar Senin 2012-02-24 02:19:19 PST
Comment on attachment 128690 [details]
Patch

Clearing flags on attachment: 128690

Committed r108760: <http://trac.webkit.org/changeset/108760>
Comment 3 Sergio Villar Senin 2012-02-24 02:19:26 PST
All reviewed patches have been landed.  Closing bug.