RESOLVED FIXED 79409
[v8] when a named item on document goes out of scope, actually remove it 
https://bugs.webkit.org/show_bug.cgi?id=79409
Summary [v8] when a named item on document goes out of scope, actually remove it
jochen
Reported 2012-02-23 15:29:43 PST
[v8] when a named item on document goes out of scope, actually remove it
Attachments
Patch (3.88 KB, patch)
2012-02-23 15:32 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (4.19 KB, patch)
2012-02-24 01:36 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-02-23 15:32:05 PST
Created attachment 128569 [details] Patch
Adam Barth
Comment 2 2012-02-23 16:00:06 PST
Comment on attachment 128569 [details] Patch Ok. Did you check the maps site that had the trouble before?
Adam Barth
Comment 3 2012-02-23 16:00:24 PST
Can you add links the bug where this change was rolled out before?
WebKit Review Bot
Comment 4 2012-02-23 16:02:19 PST
Comment on attachment 128569 [details] Patch Attachment 128569 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11576487 New failing tests: fast/dom/HTMLDocument/document-special-properties.html plugins/object-embed-plugin-scripting.html
jochen
Comment 5 2012-02-23 16:03:03 PST
I'll look into the failing tests and check the maps site tomorrow
jochen
Comment 6 2012-02-24 01:36:44 PST
Created attachment 128684 [details] Patch
anton muhin
Comment 7 2012-02-24 02:22:52 PST
Comment on attachment 128684 [details] Patch Nice and thanks!
WebKit Review Bot
Comment 8 2012-02-24 05:38:20 PST
The commit-queue encountered the following flaky tests while processing attachment 128684 [details]: fast/files/read-blob-async.html bug 79481 (author: jianli@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 9 2012-02-24 05:40:44 PST
Comment on attachment 128684 [details] Patch Clearing flags on attachment: 128684 Committed r108780: <http://trac.webkit.org/changeset/108780>
WebKit Review Bot
Comment 10 2012-02-24 05:40:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.