Bug 79409 - [v8] when a named item on document goes out of scope, actually remove it
Summary: [v8] when a named item on document goes out of scope, actually remove it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 15:29 PST by jochen
Modified: 2012-02-24 05:40 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.88 KB, patch)
2012-02-23 15:32 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (4.19 KB, patch)
2012-02-24 01:36 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-02-23 15:29:43 PST
[v8] when a named item on document goes out of scope, actually remove it
Comment 1 jochen 2012-02-23 15:32:05 PST
Created attachment 128569 [details]
Patch
Comment 2 Adam Barth 2012-02-23 16:00:06 PST
Comment on attachment 128569 [details]
Patch

Ok.  Did you check the maps site that had the trouble before?
Comment 3 Adam Barth 2012-02-23 16:00:24 PST
Can you add links the bug where this change was rolled out before?
Comment 4 WebKit Review Bot 2012-02-23 16:02:19 PST
Comment on attachment 128569 [details]
Patch

Attachment 128569 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11576487

New failing tests:
fast/dom/HTMLDocument/document-special-properties.html
plugins/object-embed-plugin-scripting.html
Comment 5 jochen 2012-02-23 16:03:03 PST
I'll look into the failing tests and check the maps site tomorrow
Comment 6 jochen 2012-02-24 01:36:44 PST
Created attachment 128684 [details]
Patch
Comment 7 anton muhin 2012-02-24 02:22:52 PST
Comment on attachment 128684 [details]
Patch

Nice and thanks!
Comment 8 WebKit Review Bot 2012-02-24 05:38:20 PST
The commit-queue encountered the following flaky tests while processing attachment 128684 [details]:

fast/files/read-blob-async.html bug 79481 (author: jianli@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Review Bot 2012-02-24 05:40:44 PST
Comment on attachment 128684 [details]
Patch

Clearing flags on attachment: 128684

Committed r108780: <http://trac.webkit.org/changeset/108780>
Comment 10 WebKit Review Bot 2012-02-24 05:40:51 PST
All reviewed patches have been landed.  Closing bug.