Bug 78790 - Build Fix: R107894 breaks Chromium Linux Build.
Summary: Build Fix: R107894 breaks Chromium Linux Build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 79865
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-16 02:05 PST by yosin
Modified: 2012-02-28 21:28 PST (History)
3 users (show)

See Also:


Attachments
Patch 1 (2.70 KB, patch)
2012-02-16 02:26 PST, yosin
no flags Details | Formatted Diff | Diff
Patch 2 (1.41 KB, patch)
2012-02-16 02:32 PST, yosin
no flags Details | Formatted Diff | Diff
Patch 3 (2.86 KB, patch)
2012-02-16 02:44 PST, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 yosin 2012-02-16 02:26:30 PST
Created attachment 127333 [details]
Patch 1
Comment 2 yosin 2012-02-16 02:32:10 PST
Created attachment 127334 [details]
Patch 2
Comment 3 Kent Tamura 2012-02-16 02:41:58 PST
Comment on attachment 127334 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=127334&action=review

> Source/WebKit/chromium/src/WebDragData.cpp:72
> -    const HashSet<String>& types = m_private->types();
> +    const DOMStringList& types = *m_private->types();

We need to do:
RefPtr<DOMStringList> types = m_private->types();
Comment 4 yosin 2012-02-16 02:44:51 PST
Created attachment 127342 [details]
Patch 3
Comment 5 Kent Tamura 2012-02-16 02:46:30 PST
Comment on attachment 127342 [details]
Patch 3

Clearing flags on attachment: 127342

Committed r107917: <http://trac.webkit.org/changeset/107917>
Comment 6 Kent Tamura 2012-02-16 02:46:36 PST
All reviewed patches have been landed.  Closing bug.