WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78790
Build Fix: R107894 breaks Chromium Linux Build.
https://bugs.webkit.org/show_bug.cgi?id=78790
Summary
Build Fix: R107894 breaks Chromium Linux Build.
yosin
Reported
2012-02-16 02:05:56 PST
http://trac.webkit.org/changeset/107894/trunk/Source/WebCore/platform/chromium/ChromiumDataObject.h
This change is incompatible with this change:
http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/WebDragData.cpp?rev=107846
Build log
http://webkit-commit-queue.appspot.com/results/11535094
Attachments
Patch 1
(2.70 KB, patch)
2012-02-16 02:26 PST
,
yosin
no flags
Details
Formatted Diff
Diff
Patch 2
(1.41 KB, patch)
2012-02-16 02:32 PST
,
yosin
no flags
Details
Formatted Diff
Diff
Patch 3
(2.86 KB, patch)
2012-02-16 02:44 PST
,
yosin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
yosin
Comment 1
2012-02-16 02:26:30 PST
Created
attachment 127333
[details]
Patch 1
yosin
Comment 2
2012-02-16 02:32:10 PST
Created
attachment 127334
[details]
Patch 2
Kent Tamura
Comment 3
2012-02-16 02:41:58 PST
Comment on
attachment 127334
[details]
Patch 2 View in context:
https://bugs.webkit.org/attachment.cgi?id=127334&action=review
> Source/WebKit/chromium/src/WebDragData.cpp:72 > - const HashSet<String>& types = m_private->types(); > + const DOMStringList& types = *m_private->types();
We need to do: RefPtr<DOMStringList> types = m_private->types();
yosin
Comment 4
2012-02-16 02:44:51 PST
Created
attachment 127342
[details]
Patch 3
Kent Tamura
Comment 5
2012-02-16 02:46:30 PST
Comment on
attachment 127342
[details]
Patch 3 Clearing flags on attachment: 127342 Committed
r107917
: <
http://trac.webkit.org/changeset/107917
>
Kent Tamura
Comment 6
2012-02-16 02:46:36 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug