Since HTMLShadowElement and HTMLContentElement have similar functionality, we can share a lot of code for them. So it's reasonable to introduce a common base class, HTMLInsertionPoint.
Created attachment 127481 [details] Patch
Created attachment 127489 [details] Patch
If it's a base class, perhaps it should be just InsertionPoint? HTML prefix is reserved for actual HTML elements.
(In reply to comment #3) > If it's a base class, perhaps it should be just InsertionPoint? HTML prefix is reserved for actual HTML elements. OK. I'll change it so.
Created attachment 127540 [details] Patch
Comment on attachment 127540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127540&action=review > Source/WebCore/html/shadow/InsertionPoint.h:48 > +#endif // ShadowElement_h Nit: Should be InsertionPoint_h
(In reply to comment #6) > (From update of attachment 127540 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127540&action=review > > > Source/WebCore/html/shadow/InsertionPoint.h:48 > > +#endif // ShadowElement_h > > Nit: Should be InsertionPoint_h Thanks!
Created attachment 127754 [details] Patch
Comment on attachment 127754 [details] Patch Clearing flags on attachment: 127754 Committed r108207: <http://trac.webkit.org/changeset/108207>
All reviewed patches have been landed. Closing bug.