Bug 78771 - Introduce HTMLInsertionPoint which will be a common base class of HTMLShadowElement and HTMLContentElement
Summary: Introduce HTMLInsertionPoint which will be a common base class of HTMLShadowE...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 78596 78778
  Show dependency treegraph
 
Reported: 2012-02-15 18:55 PST by Shinya Kawanaka
Modified: 2012-02-19 22:00 PST (History)
7 users (show)

See Also:


Attachments
Patch (21.51 KB, patch)
2012-02-16 17:31 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (20.73 KB, patch)
2012-02-16 18:09 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (21.29 KB, patch)
2012-02-17 00:04 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (19.12 KB, patch)
2012-02-19 20:38 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-02-15 18:55:35 PST
Since HTMLShadowElement and HTMLContentElement have similar functionality, we can share a lot of code for them.
So it's reasonable to introduce a common base class, HTMLInsertionPoint.
Comment 1 Shinya Kawanaka 2012-02-16 17:31:32 PST
Created attachment 127481 [details]
Patch
Comment 2 Shinya Kawanaka 2012-02-16 18:09:29 PST
Created attachment 127489 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2012-02-16 20:10:03 PST
If it's a base class, perhaps it should be just InsertionPoint? HTML prefix is reserved for actual HTML elements.
Comment 4 Shinya Kawanaka 2012-02-16 22:19:56 PST
(In reply to comment #3)
> If it's a base class, perhaps it should be just InsertionPoint? HTML prefix is reserved for actual HTML elements.

OK. I'll change it so.
Comment 5 Shinya Kawanaka 2012-02-17 00:04:40 PST
Created attachment 127540 [details]
Patch
Comment 6 Hayato Ito 2012-02-19 20:16:37 PST
Comment on attachment 127540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127540&action=review

> Source/WebCore/html/shadow/InsertionPoint.h:48
> +#endif // ShadowElement_h

Nit: Should be InsertionPoint_h
Comment 7 Shinya Kawanaka 2012-02-19 20:38:07 PST
(In reply to comment #6)
> (From update of attachment 127540 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127540&action=review
> 
> > Source/WebCore/html/shadow/InsertionPoint.h:48
> > +#endif // ShadowElement_h
> 
> Nit: Should be InsertionPoint_h

Thanks!
Comment 8 Shinya Kawanaka 2012-02-19 20:38:59 PST
Created attachment 127754 [details]
Patch
Comment 9 WebKit Review Bot 2012-02-19 22:00:53 PST
Comment on attachment 127754 [details]
Patch

Clearing flags on attachment: 127754

Committed r108207: <http://trac.webkit.org/changeset/108207>
Comment 10 WebKit Review Bot 2012-02-19 22:00:58 PST
All reviewed patches have been landed.  Closing bug.