Bug 78706 – Renaming parameters for positioning a track cue

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Victor Carbune]

The positioning and size parameters (formerly D:, L:, T:, S:, A:) in the WebVTT spec have been renamed (vertical:, line:, position:, size:, align:)

The TextTrackCue::parseSettings method needs to be updated.

[Radar WebKit Bug Importer]

<rdar://problem/10958447>

[Eric Carlson]

Created attachment 129568 [details]
Proposed patch

[Sam Weinig]

Comment on attachment 129568 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129568&action=review

> Source/WebCore/html/track/TextTrackCue.cpp:401
> +TextTrackCue::CueSetting TextTrackCue::settingName(const String& name)
> +{
> +    DEFINE_STATIC_LOCAL(const String, verticalKeyword, ("vertical"));
> +    DEFINE_STATIC_LOCAL(const String, lineKeyword, ("line"));
> +    DEFINE_STATIC_LOCAL(const String, positionKeyword, ("position"));
> +    DEFINE_STATIC_LOCAL(const String, sizeKeyword, ("size"));
> +    DEFINE_STATIC_LOCAL(const String, alignKeyword, ("align"));
> +
> +    if (name == verticalKeyword)
> +        return Vertical;
> +    else if (name == lineKeyword)
> +        return Line;
> +    else if (name == positionKeyword)
> +        return Position;
> +    else if (name == sizeKeyword)
> +        return Size;
> +    else if (name == alignKeyword)
> +        return Align;
> +
> +    return None;
> +}

Is this common enough that we should consider using AtomicString?

[WebKit Review Bot]

Comment on attachment 129568 [details]
Proposed patch

Clearing flags on attachment: 129568

Committed r112898: <http://trac.webkit.org/changeset/112898>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.