Bug 78679 – Clean up radio button tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kent Tamura]

Clean up radio button tests

[Kent Tamura]

Created attachment 127130 [details]
Patch

[Kentaro Hara]

Comment on attachment 127130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127130&action=review

r- due to missing the diff of radio-nested-labels.html

> LayoutTests/ChangeLog:9
> +        - Split checkbox-radio-onchange.html into two.
> +        - Convert some rendering tests about radio buttons to text tests.

Maybe I wanted to see more descriptive comments. At least,

- Split checkbox-radio-onchange.html into checkbox-onchange.html and radio-onchange.html.
- Convert radio_checked.html and radio_checked_dynamic.html to text tests.

> LayoutTests/ChangeLog:19
> +        * fast/forms/radio-nested-labels.html:

This change is recognized as a binary change and I cannot see it. Would you paste the diff in comments?

> LayoutTests/fast/forms/radio-attr-order.html:6
> +<input type="radio" checked name="test_group" id="rb">

Nit: name= is not necessary.

> LayoutTests/fast/forms/radio/radio-onchange.html:7
> +<input type="radio" name="test" id="rd">

Nit: You can remove this line.

> LayoutTests/fast/forms/radio/radio-onchange.html:8
> +<input type="radio" name="test" id="rd2" onchange="handleChange()">

Nit: name= is not necessary.

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 127130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127130&action=review
> 
> r- due to missing the diff of radio-nested-labels.html

Oh, svn:mime-type of radio-nested-labels.html is application/octet-stream...

> > LayoutTests/fast/forms/radio-attr-order.html:6
> > +<input type="radio" checked name="test_group" id="rb">
> 
> Nit: name= is not necessary.

Existence of name attribute affects the behavior of radio buttons in some cases.  We should not change it.

[Kent Tamura]

Created attachment 127152 [details]
Patch 2

[Kentaro Hara]

Comment on attachment 127152 [details]
Patch 2

Looks OK!

[Kent Tamura]

Comment on attachment 127152 [details]
Patch 2

Thank you for reviewing!

[WebKit Review Bot]

Comment on attachment 127152 [details]
Patch 2

Clearing flags on attachment: 127152

Committed r107805: <http://trac.webkit.org/changeset/107805>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 127152 [details]:

animations/suspend-resume-animation-events.html bug 51002 (author: [e-mail])
The commit-queue is continuing to process your patch.