RESOLVED FIXED78429
Get rid of WebCore::URLString 
https://bugs.webkit.org/show_bug.cgi?id=78429
Summary Get rid of WebCore::URLString
Benjamin Poulain
Reported 2012-02-11 18:09:28 PST
WebCore::URLString() is totally unused. We introduced WTF::URLString() in https://bugs.webkit.org/show_bug.cgi?id=77291
Attachments
Patch (9.15 KB, patch)
2012-02-11 18:16 PST, Benjamin Poulain 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-02-11 18:16:30 PST
Created attachment 126662 [details] Patch
Adam Barth
Comment 2 2012-02-11 18:19:39 PST
Comment on attachment 126662 [details] Patch Ok.
Adam Barth
Comment 3 2012-02-11 18:20:03 PST
WebCore::URLString was something of a dream. :)
Benjamin Poulain
Comment 4 2012-02-11 18:21:54 PST
(In reply to comment #3) > WebCore::URLString was something of a dream. :) I think we need a stronger concept for WTF::URLString. I would like the class to enforce the URL is well formed. Invalid URLs crawling as String keep me up at night. What is your opinion?
Benjamin Poulain
Comment 5 2012-02-11 18:35:20 PST
Committed r107497: <http://trac.webkit.org/changeset/107497>
Adam Barth
Comment 6 2012-02-11 19:33:05 PST
Yeah, the goal of WebCore::URLString was to keep track of which Strings were actually legitimate/canonicalized URLs. There was going to a companion class called ParsedURL which would let you extract the various components of a parsed URL (i.e., what KURL can do for you). We were going to use URLString when the storage overhead of remembering the segmentation of the URL was more costly than just recomputing it as needed.
Note You need to log in before you can comment on or make changes to this bug.