Bug 77291 - Add back WTFURL to WebKit
Summary: Add back WTFURL to WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-28 16:29 PST by Benjamin Poulain
Modified: 2012-02-11 22:32 PST (History)
1 user (show)

See Also:


Attachments
Patch (92.16 KB, patch)
2012-01-28 16:40 PST, Benjamin Poulain
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-01-28 16:29:59 PST
Add back what was removed by r86787.
Comment 1 Benjamin Poulain 2012-01-28 16:40:26 PST
Created attachment 124457 [details]
Patch
Comment 2 Adam Barth 2012-01-28 16:55:52 PST
Comment on attachment 124457 [details]
Patch

There's still an ongoing thread on webkit-dev about this work, but I think it's fine to proceed as long as you're aware of the issues being discussed there.
Comment 3 Benjamin Poulain 2012-01-28 17:40:07 PST
(In reply to comment #2)
> (From update of attachment 124457 [details])
> There's still an ongoing thread on webkit-dev about this work, but I think it's fine to proceed as long as you're aware of the issues being discussed there.

Yep, I'll wait until there is some clear path forward before landing this.
Comment 4 Benjamin Poulain 2012-02-11 19:24:50 PST
Are you OK if I land this?

I think we have an idea of where to go from here:
-no dependency on anything else in WTF
-at some point WTFURL will have to be compiled as a static library for Chromium


Next I think I am gonna export the headers for WebCore and make an empty skeleton of KURL based on ParsedURL + a WTFString for invalid URL.
Comment 5 Adam Barth 2012-02-11 19:30:59 PST
That sounds like a good plan.  I'm not sure we have 100% buy-in from all the stakeholders, but if you're ok proceeding knowing that risk is out there, I'm happy to review your patches.
Comment 6 Benjamin Poulain 2012-02-11 22:32:49 PST
Committed r107502: <http://trac.webkit.org/changeset/107502>