Bug 78423 – [DFG] Misuse of WeakJSConstants in silentFillGPR code.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

<rdar://problem/10849353>

[Filip Pizlo]

Created attachment 126647 [details]
the patch

[Filip Pizlo]

Going to attempt to write a test that repros this.  If I can't after some amount of trying then I'll land without a test.

[Filip Pizlo]

Created attachment 126655 [details]
the patch with test case

[WebKit Review Bot]

Attachment 126655 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/JavaScriptCore/ChangeLog:31:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:32:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

http://trac.webkit.org/changeset/107492

[Eric Seidel (no email)]

Comment on attachment 126655 [details]
the patch with test case

View in context: https://bugs.webkit.org/attachment.cgi?id=126655&action=review

Why does this test repeat 1000 times?

> Source/JavaScriptCore/ChangeLog:20
> +	https://bugs.webkit.org/show_bug.cgi?id=78062
> +	<rdar://problem/10326439> <rdar://problem/10824839>

Are these tabs?

[Geoffrey Garen]

r=me

Please replace your tabs with spaces.

> Why does this test repeat 1000 times?

It's the best way we have to test the optimizing compiler. :(

[Filip Pizlo]

(In reply to comment #7)
> (From update of attachment 126655 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126655&action=review
> 
> Why does this test repeat 1000 times?
> 
> > Source/JavaScriptCore/ChangeLog:20
> > +	https://bugs.webkit.org/show_bug.cgi?id=78062
> > +	<rdar://problem/10326439> <rdar://problem/10824839>
> 
> Are these tabs?

Yes. :-(  Stupid emacs!  Somehow I missed this, but fixed it in a later commit.

[Filip Pizlo]

(In reply to comment #8)
> r=me
> 
> Please replace your tabs with spaces.

Already fixed!

By the way, I landed the code with the test case (thanks to Sam's rubber stamp) in http://trac.webkit.org/changeset/107492

> 
> > Why does this test repeat 1000 times?
> 
> It's the best way we have to test the optimizing compiler. :(