Bug 78062 – DFG should have polymorphic put_by_id caching

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

<rdar://problem/10326439>

[Filip Pizlo]

Created attachment 125968 [details]
the patch

Still need some build foo, but other than that it seems to work.

[WebKit Review Bot]

Attachment 125968 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/bytecode/PolymorphicPutByIdList.h:156:  The parameter name "putKind" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/PolymorphicPutByIdList.h:157:  The parameter name "stubInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/StructureStubInfo.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 125971 [details]
the patch

Added build goodness.

[WebKit Review Bot]

Attachment 125971 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/bytecode/StructureStubInfo.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 125979 [details]
the patch

[WebKit Review Bot]

Attachment 125979 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/bytecode/StructureStubInfo.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Comment on attachment 125979 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125979&action=review

No baseline support? :-D

Once this is in we can add support for setters!!!!

> Source/JavaScriptCore/runtime/WriteBarrier.h:82
> +    
> +    // This is meant to be used like operator=, but is called copyFrom instead, in
> +    // order to kindly inform the C++ compiler that its advice is not appreciated.
> +    void copyFrom(const WriteBarrierBase<T>& other)
> +    {
> +        m_cell = other.m_cell;
> +    }

What was it complaining about?

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/107485