Bug 78341 – [WIN] Add abstraction for HWND_MESSAGE

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

[WIN] Add abstraction for HWND_MESSAGE

[Patrick R. Gansterer]

Created attachment 126483 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 126483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126483&action=review

> Source/WebCore/platform/win/WindowsExtras.h:36
> +#ifdef HWND_MESSAGE
> +const HWND kHwndMessage = HWND_MESSAGE;
> +#else
> +const HWND kHwndMessage = 0;
> +#endif

Why not just do this?

#ifndef HWND_MESSAGE
const HWND HWND_MESSAGE = 0;
#endif

Then we could use HWND_MESSAGE everywhere.

[Patrick R. Gansterer]

Created attachment 126777 [details]
Patch

[WebKit Review Bot]

Attachment 126777 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/win/WindowsExtras.h:33:  HWND_MESSAGE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 126777 [details]
Patch

Clearing flags on attachment: 126777

Committed r107592: <http://trac.webkit.org/changeset/107592>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.