Bug 78340 - Add WindowsExtras.h
Summary: Add WindowsExtras.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 76781 78341
  Show dependency treegraph
 
Reported: 2012-02-10 02:22 PST by Patrick R. Gansterer
Modified: 2012-02-13 08:30 PST (History)
1 user (show)

See Also:


Attachments
Patch (5.59 KB, patch)
2012-02-10 02:26 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (5.59 KB, patch)
2012-02-10 02:49 PST, Patrick R. Gansterer
aroben: review+
aroben: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-02-10 02:22:16 PST
Add WindowsExtras.h
Comment 1 Patrick R. Gansterer 2012-02-10 02:26:02 PST
Created attachment 126482 [details]
Patch
Comment 2 Patrick R. Gansterer 2012-02-10 02:49:50 PST
Created attachment 126484 [details]
Patch
Comment 3 Adam Roben (:aroben) 2012-02-13 07:30:12 PST
Comment on attachment 126484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126484&action=review

> Source/WebCore/platform/win/WindowsExtras.h:32
> +inline void* getWindowPointer(HWND hWnd, int index = 0)

I think it would be clearer to make index a required parameter. (Ditto for the setter.)
Comment 4 Patrick R. Gansterer 2012-02-13 08:30:56 PST
Committed r107574: <http://trac.webkit.org/changeset/107574>