WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78340
Add WindowsExtras.h
https://bugs.webkit.org/show_bug.cgi?id=78340
Summary
Add WindowsExtras.h
Patrick R. Gansterer
Reported
2012-02-10 02:22:16 PST
Add WindowsExtras.h
Attachments
Patch
(5.59 KB, patch)
2012-02-10 02:26 PST
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Patch
(5.59 KB, patch)
2012-02-10 02:49 PST
,
Patrick R. Gansterer
aroben
: review+
aroben
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2012-02-10 02:26:02 PST
Created
attachment 126482
[details]
Patch
Patrick R. Gansterer
Comment 2
2012-02-10 02:49:50 PST
Created
attachment 126484
[details]
Patch
Adam Roben (:aroben)
Comment 3
2012-02-13 07:30:12 PST
Comment on
attachment 126484
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=126484&action=review
> Source/WebCore/platform/win/WindowsExtras.h:32 > +inline void* getWindowPointer(HWND hWnd, int index = 0)
I think it would be clearer to make index a required parameter. (Ditto for the setter.)
Patrick R. Gansterer
Comment 4
2012-02-13 08:30:56 PST
Committed
r107574
: <
http://trac.webkit.org/changeset/107574
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug