RESOLVED FIXED Bug 78328
Remove [ConvertingNullStringTo] from CloseEvent.idl 
https://bugs.webkit.org/show_bug.cgi?id=78328
Summary Remove [ConvertingNullStringTo] from CloseEvent.idl
Kentaro Hara
Reported 2012-02-09 23:25:07 PST
In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo]. In bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]. In conclusion, we should replace [ConvertingNullStringTo] with [TreatReturnedNullStringAs].
Attachments
Patch (4.39 KB, patch)
2012-02-09 23:32 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2012-02-10 00:04 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-09 23:32:54 PST
Created attachment 126464 [details] Patch
Adam Barth
Comment 2 2012-02-09 23:37:28 PST
Comment on attachment 126464 [details] Patch Have you cross-checked this with the spec?
Kentaro Hara
Comment 3 2012-02-10 00:04:37 PST
Created attachment 126467 [details] Patch
Kentaro Hara
Comment 4 2012-02-10 00:05:23 PST
(In reply to comment #2) > (From update of attachment 126464 [details]) > Have you cross-checked this with the spec? The spec says "The reason attribute must return the value it was initialized to. When the object is created, this attribute must be initialized to empty string.". http://dev.w3.org/html5/websockets/#event-definitions So we should simply remove [ConvertingNullStringTo]. Uploaded a revised patch.
WebKit Review Bot
Comment 5 2012-02-10 01:28:23 PST
Comment on attachment 126467 [details] Patch Clearing flags on attachment: 126467 Committed r107382: <http://trac.webkit.org/changeset/107382>
WebKit Review Bot
Comment 6 2012-02-10 01:28:27 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2012-02-13 15:31:58 PST
All sounds fine, but what about test coverage?
Kentaro Hara
Comment 8 2012-02-13 16:01:34 PST
(In reply to comment #7) > All sounds fine, but what about test coverage? Darin: The following existing test is in close-event-constructor.html: shouldBeEqualToString("new CloseEvent('eventType', { reason: '' }).reason", ""); Fortunately, we didn't need to change the test result (since [ConvertingNullStringTo] was typo and had not been working at all).
Darin Adler
Comment 9 2012-02-14 15:33:14 PST
(In reply to comment #8) > Fortunately, we didn't need to change the test result So if we had added the correctly spelled attribute the test would have failed?
Kentaro Hara
Comment 10 2012-02-14 15:39:14 PST
(In reply to comment #9) > (In reply to comment #8) > > Fortunately, we didn't need to change the test result > > So if we had added the correctly spelled attribute the test would have failed? Yes.
Note You need to log in before you can comment on or make changes to this bug.