Bug 78108 - Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
Summary: Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 77393
  Show dependency treegraph
Reported: 2012-02-08 05:47 PST by Kentaro Hara
Modified: 2012-02-09 16:56 PST (History)
7 users (show)

See Also:

Patch (43.86 KB, patch)
2012-02-08 05:50 PST, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
rebased patch for commit (44.06 KB, patch)
2012-02-08 16:04 PST, Kentaro Hara
haraken: commit-queue-
Details | Formatted Diff | Diff
rebased patch for commit (43.90 KB, patch)
2012-02-08 23:14 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-08 05:47:22 PST
[ConvertNullStringTo=] is not descriptive. To clarify that it specifies the behavior when the null string is returned by WebCore, we can rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=], also for naming consistency with [TreatNullAs] and [TreatUndefinedAs].
Comment 1 Kentaro Hara 2012-02-08 05:50:13 PST
Created attachment 126067 [details]
Comment 2 WebKit Review Bot 2012-02-08 10:37:15 PST
Comment on attachment 126067 [details]

Rejecting attachment 126067 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
patching file Source/WebCore/storage/Storage.idl
patching file Source/WebCore/storage/StorageEvent.idl
patching file Source/WebCore/websockets/WebSocket.idl
patching file Source/WebCore/xml/XMLHttpRequest.idl
patching file Source/WebCore/xml/XPathNSResolver.idl
patching file Source/WebCore/xml/XSLTProcessor.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11449493
Comment 3 Kentaro Hara 2012-02-08 16:04:02 PST
Created attachment 126173 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2012-02-08 22:34:31 PST
Comment on attachment 126173 [details]
rebased patch for commit

Rejecting attachment 126173 [details] from commit-queue.

New failing tests:
Full output: http://queues.webkit.org/results/11487095
Comment 5 Kentaro Hara 2012-02-08 23:14:11 PST
Created attachment 126244 [details]
rebased patch for commit
Comment 6 Kentaro Hara 2012-02-08 23:20:46 PST
Committed r107186: <http://trac.webkit.org/changeset/107186>
Comment 7 Kentaro Hara 2012-02-09 03:21:03 PST
I rolled out the patch due to dependency with r107182. I'll re-land it after the patch for bug 78200 is landed successfully.
Comment 8 Kentaro Hara 2012-02-09 16:56:57 PST
Committed r107312: <http://trac.webkit.org/changeset/107312>