Bug 78115 – Switch svg/custom tests to repaint harness

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Switch svg/custom tests to repaint harness. Follow-up for bug 77736.
Next and last is svg/dynamic-updates.

[Nikolas Zimmermann]

Created attachment 126085 [details]
Patch

[Nikolas Zimmermann]

Created attachment 126262 [details]
Patch v2

[Andreas Kling]

Comment on attachment 126262 [details]
Patch v2

LGTM!

[Nikolas Zimmermann]

Committed r107207: <http://trac.webkit.org/changeset/107207>

[WebKit Review Bot]

Comment on attachment 126262 [details]
Patch v2

Attachment 126262 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11487197

New failing tests:
platform/chromium/compositing/layout-width-change.html
svg/carto.net/slider.svg

[Nikolas Zimmermann]

(In reply to comment #5)
> (From update of attachment 126262 [details])
> Attachment 126262 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11487197
> 
> New failing tests:
> platform/chromium/compositing/layout-width-change.html
> svg/carto.net/slider.svg
For the record, these are not related to this bug, it only changed layout tests, and none in those directories.

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r107207: <http://trac.webkit.org/changeset/107207>

Reopen, because it made the following tests assert on Qt in debug mode:
svg/custom/mask-child-changes.svg
svg/custom/mask-invalidation.svg
svg/custom/absolute-sized-content-with-resources.xhtml

ASSERTION FAILED: m_transparencyCount > 0
../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer()

[Nikolas Zimmermann]

(In reply to comment #7)
> (In reply to comment #4)
> > Committed r107207: <http://trac.webkit.org/changeset/107207>
> 
> Reopen, because it made the following tests assert on Qt in debug mode:
> svg/custom/mask-child-changes.svg
> svg/custom/mask-invalidation.svg
> svg/custom/absolute-sized-content-with-resources.xhtml
> 
> ASSERTION FAILED: m_transparencyCount > 0
> ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer()

hm, I guess this only exposes a Qt bug - that's now visible due the changed timing. It's not something I can fix without a Qt build - You forgot to reopen btw.

[Csaba Osztrogonác]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #4)
> > > Committed r107207: <http://trac.webkit.org/changeset/107207>
> > 
> > Reopen, because it made the following tests assert on Qt in debug mode:
> > svg/custom/mask-child-changes.svg
> > svg/custom/mask-invalidation.svg
> > svg/custom/absolute-sized-content-with-resources.xhtml
> > 
> > ASSERTION FAILED: m_transparencyCount > 0
> > ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer()
> 
> hm, I guess this only exposes a Qt bug - that's now visible due the changed timing. It's not something I can fix without a Qt build - You forgot to reopen btw.

:-(

Zoltán or Reni or any other Qt and svg expert, could you check this?

[Eric Seidel (no email)]

Comment on attachment 126262 [details]
Patch v2

Cleared Andreas Kling's review+ from obsolete attachment 126262 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Nikolas Zimmermann]

I'm closing this bug, we can move the Qt specific fixing into bug 78332.

[Stephen Chenney]

Committed r113360: <http://trac.webkit.org/changeset/113360>