Bug 77954 - MediaStream API: Add the onstatechange callback to PeerConnection
Summary: MediaStream API: Add the onstatechange callback to PeerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-02-07 02:37 PST by Tommy Widenflycht
Modified: 2012-02-08 01:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2012-02-07 02:42 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-02-07 02:37:48 PST 
The current implementation is missing the onstatechange callback. Note that the patch doesn't contain iceState or sdpState, that will be added when the dust settles regarding ROAP/JSEP in the standard.
Comment 1 Tommy Widenflycht 2012-02-07 02:42:10 PST 
Created attachment 125796 [details]
Patch
Comment 2 Adam Barth 2012-02-07 10:38:48 PST 
Comment on attachment 125796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125796&action=review

> Source/WebCore/ChangeLog:10
> +        Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

How close are we to being able to write these tests?  It feels like we've got a lot of this code landed now.
Comment 3 Tommy Widenflycht 2012-02-08 00:54:49 PST 
Comment on attachment 125796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125796&action=review

>> Source/WebCore/ChangeLog:10
>> +        Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
> 
> How close are we to being able to write these tests?  It feels like we've got a lot of this code landed now.

Expect the first rough patch later this week :) Agree that it is long overdue...
Comment 4 Adam Barth 2012-02-08 00:59:07 PST 
> Expect the first rough patch later this week :)

Yay!
Comment 5 WebKit Review Bot 2012-02-08 01:52:37 PST 
Comment on attachment 125796 [details]
Patch

Clearing flags on attachment: 125796

Committed r107054: <http://trac.webkit.org/changeset/107054>
Comment 6 WebKit Review Bot 2012-02-08 01:52:42 PST 
All reviewed patches have been landed.  Closing bug.