Bug 77900 - zvmul incorrectly multiplies complex arrays on Windows.
Summary: zvmul incorrectly multiplies complex arrays on Windows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on:
Blocks: 75933
  Show dependency treegraph
 
Reported: 2012-02-06 14:27 PST by Raymond Toy
Modified: 2012-02-06 15:23 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2012-02-06 14:44 PST, Raymond Toy
kbr: review+
rtoy: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2012-02-06 14:27:06 PST
WebCore::VectorMath::zvmul incorrectly multiplies complex vectors on Windows, breaking convolution demos.
Comment 1 Raymond Toy 2012-02-06 14:44:11 PST
Created attachment 125709 [details]
Patch
Comment 2 Chris Rogers 2012-02-06 14:47:31 PST
Looks good.
Comment 3 Raymond Toy 2012-02-06 14:48:13 PST
Actually, this also affects Linux, if the arrays are not aligned for the SSE2 code to be used.

As a side effect, this fixes the test failure on Windows for the convolution-mono-mono test (but 75933).  (Unfortunate that the convolution test was done after bug 74842 was landed.)
Comment 4 Kenneth Russell 2012-02-06 14:48:21 PST
Comment on attachment 125709 [details]
Patch

rs=me
Comment 5 Chris Rogers 2012-02-06 15:23:54 PST
Committed r106864: <http://trac.webkit.org/changeset/106864>