In bug 77693, we have added "JS" prefix to several JSC specific IDLs. In this bug, we add "JS" prefix to the remaining JSC specific IDLs. Specifically, we rename IDLs as follows: [CustomDefineGetter] => [JSCustomDefineGetter] [CustomDefineSetter] => [JSCustomDefineSetter] [CustomPrototypeDefineGetter] => [JSCustomPrototypeDefineGetter] [GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency with [JSGenerateToJS] and [JSCustomToNativeObject]) [DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS", should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])
Created attachment 125558 [details] Patch
Created attachment 125758 [details] Patch
Comment on attachment 125758 [details] Patch Darin: Since there was a big conflict with bug 77451, I rebased the patch. Just in case, would you take another look at it? Thanks.
Comment on attachment 125758 [details] Patch I didn’t spot any mistakes, but I am not sure I would have. r=me
Comment on attachment 125758 [details] Patch Rejecting attachment 125758 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 120754 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 120754. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11453042
Created attachment 125990 [details] patch for commit
Comment on attachment 125990 [details] patch for commit Rejecting attachment 125990 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 120754 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 120754. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11460267
Committed r107041: <http://trac.webkit.org/changeset/107041>