Bug 77451 - Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
Summary: Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
: 71493 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-31 10:22 PST by Gavin Barraclough
Modified: 2012-02-29 00:26 PST (History)
5 users (show)

See Also:


Attachments
The patch (38.63 KB, patch)
2012-01-31 10:24 PST, Gavin Barraclough
sam: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
build fixed for windows & qt (39.76 KB, patch)
2012-01-31 17:42 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
More win build fix (40.21 KB, patch)
2012-01-31 18:13 PST, Gavin Barraclough
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
More qt build fix (41.79 KB, patch)
2012-01-31 20:28 PST, Gavin Barraclough
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
More build fixes (42.21 KB, patch)
2012-02-01 16:23 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
More win build fix (42.59 KB, patch)
2012-02-04 18:27 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Merged up (40.46 KB, patch)
2012-02-05 21:21 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-01-31 10:22:08 PST
These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.  Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.
Comment 1 Gavin Barraclough 2012-01-31 10:24:05 PST
Created attachment 124769 [details]
The patch
Comment 2 WebKit Review Bot 2012-01-31 10:26:05 PST
Attachment 124769 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-01-31 13:09:14 PST
Comment on attachment 124769 [details]
The patch

Attachment 124769 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11387104
Comment 4 Gavin Barraclough 2012-01-31 17:42:23 PST
Created attachment 124861 [details]
build fixed for windows & qt
Comment 5 Gavin Barraclough 2012-01-31 18:13:55 PST
Created attachment 124864 [details]
More win build fix
Comment 6 Early Warning System Bot 2012-01-31 20:26:32 PST
Comment on attachment 124864 [details]
More win build fix

Attachment 124864 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11393262
Comment 7 Gavin Barraclough 2012-01-31 20:28:45 PST
Created attachment 124876 [details]
More qt build fix
Comment 8 WebKit Review Bot 2012-01-31 20:33:01 PST
Attachment 124876 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebKit/qt/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Early Warning System Bot 2012-01-31 21:38:33 PST
Comment on attachment 124876 [details]
More qt build fix

Attachment 124876 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11386318
Comment 10 Gavin Barraclough 2012-02-01 16:23:02 PST
Created attachment 125039 [details]
More build fixes
Comment 11 WebKit Review Bot 2012-02-01 16:25:50 PST
Attachment 125039 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebKit/qt/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Gavin Barraclough 2012-02-04 18:27:32 PST
Created attachment 125510 [details]
More win build fix
Comment 13 Gavin Barraclough 2012-02-05 21:21:07 PST
Created attachment 125564 [details]
Merged up
Comment 14 Gavin Barraclough 2012-02-06 00:56:25 PST
Fixed in r106783
Comment 15 Gavin Barraclough 2012-02-29 00:26:55 PST
*** Bug 71493 has been marked as a duplicate of this bug. ***