Bug 71493 - __defineGetter__/__defineSetter__ should be implemented in terms of JSObject::defineOwnProperty
Summary: __defineGetter__/__defineSetter__ should be implemented in terms of JSObject:...
Status: RESOLVED DUPLICATE of bug 77451
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-03 11:50 PDT by Sam Weinig
Modified: 2012-02-29 00:26 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-11-03 11:50:13 PDT 
Right now, __defineGetter__/__defineSetter__ are implemented by calling virtual (actually static on the MethodTable) JSObject::defineGetter/defineSetter, but we could implement it in terms of JSObject::defineOwnProperty and remove two virtual functions from the MethodTable.  This would also be more forward looking, by implementing the legacy __defineGetter__/__defineSetter__ in terms of the now specified defineOwnProperty.

If we do this, we need to make sure we continue block the specific uses of __defineGetter__/__defineSetter__ in JSLocation and JSDOMWindow.
Comment 1 Gavin Barraclough 2012-02-29 00:26:55 PST 

*** This bug has been marked as a duplicate of bug 77451 ***