Bug 77619 – Web Inspector: Introduce "Copy XPath" popup menu item for DOM elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Patch to follow

[Alexander Pavlov (apavlov)]

Created attachment 125134 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 125134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125134&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:539
> +    xPathValue: function(optimized)

Should be private as well as _xPathIndex()?

> Source/WebCore/inspector/front-end/DOMAgent.js:549
> +                return new  WebInspector.DOMNode.XPathStep("//*[@id=\"" + this.getAttribute("id") + "\"]", true);

double space between new and WebInspector.

> Source/WebCore/inspector/front-end/DOMAgent.js:580
> +     * @return -1 in case of error, 0 if no siblings matching the same expression, <XPath index among the same expression-matching sibling nodes> otherwise.

Please add type annotation here and move description to a separate comment inside function.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1710
> +        this.representedObject.copyXPath(true);

Please add this argument to copyXPath() method, r- for that.

[Alexander Pavlov (apavlov)]

Created attachment 125333 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 125333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125333&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:300
> +    copyXPath: function(optimized)

Please add @param annotation for optimized.

> Source/WebCore/inspector/front-end/DOMAgent.js:520
> +    xPath: function(optimized)

ditto

> Source/WebCore/inspector/front-end/DOMAgent.js:544
> +    _xPathValue: function(optimized)

ditto

[Alexander Pavlov (apavlov)]

Committed r106664: <http://trac.webkit.org/changeset/106664>