Bug 77429 – [Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Fady Samuel]

m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true, because
WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.
The simplest solution is to simply get rid of the early return in WebViewImpl::setPageScaleFactorPreservingScrollOffset.

[Fady Samuel]

Created attachment 124718 [details]
Patch

[WebKit Review Bot]

Attachment 124718 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
From git://git.webkit.org/WebKit
   baf92d92..7fbc464 master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 106356 = baf92d9262faea6b0ee0b2ada47f821fc179c331
r106357 = 7fbc464108a336b4b5cc9d5561e013ca51529334
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Fisher (:fishd, Google)]

Comment on attachment 124718 [details]
Patch

Is there a way to write a regression test for this bug?

[Fady Samuel]

(In reply to comment #3)
> (From update of attachment 124718 [details])
> Is there a way to write a regression test for this bug?

I'm not sure how, the viewport gets recomputed but nothing changes from the perspective of the webpage so I don't know how to write a layout test for this. The problem is unnecessary work is being done that just burns cycles.

[WebKit Review Bot]

Comment on attachment 124718 [details]
Patch

Clearing flags on attachment: 124718

Committed r106395: <http://trac.webkit.org/changeset/106395>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.