Bug 77378 - Enable memcache on webkit-perf.appspot.com
Summary: Enable memcache on webkit-perf.appspot.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 77258
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-01-30 15:58 PST by Ryosuke Niwa
Modified: 2012-01-30 17:54 PST (History)
3 users (show)

See Also:

Attachments
Enables memcache (11.96 KB, patch)
2012-01-30 16:20 PST, Ryosuke Niwa 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-01-30 15:58:43 PST 
webkit-perf.appspot.com is super slow due to each page accessing the storage on every page access. We should enable memcache on all JSON APIs.
Comment 1 Ryosuke Niwa 2012-01-30 16:20:05 PST 
Created attachment 124623 [details]
Enables memcache
Comment 2 WebKit Review Bot 2012-01-30 16:22:06 PST 
Attachment 124623 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Websites/webkit-perf.appspot..." exit_code: 1

Websites/webkit-perf.appspot.com/dashboard_handler.py:43:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2012-01-30 16:23:07 PST 
";" in content-type again :(
Comment 4 Adam Barth 2012-01-30 17:32:47 PST 
Comment on attachment 124623 [details]
Enables memcache

View in context: https://bugs.webkit.org/attachment.cgi?id=124623&action=review

Feel free to ignore these style issues.  (If you'd like to ignore them, let me know and I'll stop randomly flagging them.)

> Websites/webkit-perf.appspot.com/report_handler.py:89
> +        for testName, result in self._body['results'].iteritems():

testName => test_name

> Websites/webkit-perf.appspot.com/runs_handler.py:64
> +        cacheKey = Test.cacheKey(testId, branchId, platformId)

cacheKey => cache_key
Comment 5 Ryosuke Niwa 2012-01-30 17:34:49 PST 
I'll land the current patch as is and will rename all variables and function names on a dedicated bug.
Comment 6 Ryosuke Niwa 2012-01-30 17:36:23 PST 
Committed r106308: <http://trac.webkit.org/changeset/106308>