Bug 77088 - [GStreamer] disable GStreamerGWorld when building against 0.11
Summary: [GStreamer] disable GStreamerGWorld when building against 0.11
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77005
  Show dependency tree / graph
 
Reported: 2012-01-26 02:59 PST by Philippe Normand
Modified: 2012-03-06 07:03 PST (History)
5 users (show)

See Also:

Attachments
disable GStreamerGWorld when building against 0.11 (8.19 KB, patch)
2012-01-26 03:32 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
disable GStreamerGWorld when building against 0.11 (13.84 KB, patch)
2012-03-06 01:25 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
disable GStreamerGWorld when building against 0.11 (18.04 KB, patch)
2012-03-06 01:34 PST, Philippe Normand 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-01-26 02:59:06 PST 
SSIA
Comment 1 Philippe Normand 2012-01-26 03:32:00 PST 
Created attachment 124095 [details]
disable GStreamerGWorld when building against 0.11
Comment 2 Sebastian Dröge (slomo) 2012-01-30 02:25:16 PST 
Looks good and makes sense to disable now if it is going to be dropped soon anyway
Comment 3 Philippe Normand 2012-02-27 10:16:16 PST 
Comment on attachment 124095 [details]
disable GStreamerGWorld when building against 0.11

The Qt and maybe EFL ports need an update, I'll check that tomorrow.
Comment 4 Philippe Normand 2012-03-06 01:25:45 PST 
Created attachment 130328 [details]
disable GStreamerGWorld when building against 0.11
Comment 5 Philippe Normand 2012-03-06 01:34:10 PST 
Created attachment 130331 [details]
disable GStreamerGWorld when building against 0.11
Comment 6 Martin Robinson 2012-03-06 06:43:45 PST 
Comment on attachment 130331 [details]
disable GStreamerGWorld when building against 0.11

View in context: https://bugs.webkit.org/attachment.cgi?id=130331&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:22
>  #include "GStreamerGWorld.h"
> +#ifndef GST_API_VERSION_1

I prefer the compound statement that you use below here. :)

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:24
> +#ifndef GST_API_VERSION_1
>  #if ENABLE(VIDEO) && USE(GSTREAMER)

Ditto.
Comment 7 Philippe Normand 2012-03-06 07:03:16 PST 
Committed r109915: <http://trac.webkit.org/changeset/109915>