Bug 76589 - Assigning to Element.prefix should throw exception when using illegal characters
: Assigning to Element.prefix should throw exception when using illegal characters
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks: 76198
  Show dependency treegraph
 
Reported: 2012-01-18 17:09 PST by Adam Barth
Modified: 2012-01-19 16:02 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.05 KB, patch)
2012-01-18 17:12 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (7.02 KB, patch)
2012-01-18 21:07 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2012-01-18 21:26 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-01-18 17:09:50 PST
Assigning to Element.prefix should throw exception when using illegal characters
Comment 1 Adam Barth 2012-01-18 17:12:21 PST
Created attachment 123041 [details]
Patch
Comment 2 Eric Seidel 2012-01-18 17:28:12 PST
Comment on attachment 123041 [details]
Patch

Um... I think we need at least 10x this many tests for this much code. :(
Comment 3 Adam Barth 2012-01-18 17:35:05 PST
Comment on attachment 123041 [details]
Patch

ok.
Comment 4 Adam Barth 2012-01-18 21:07:15 PST
Created attachment 123064 [details]
Patch
Comment 5 Adam Barth 2012-01-18 21:26:29 PST
Created attachment 123068 [details]
Patch
Comment 6 WebKit Review Bot 2012-01-18 23:39:56 PST
Comment on attachment 123068 [details]
Patch

Clearing flags on attachment: 123068

Committed r105388: <http://trac.webkit.org/changeset/105388>
Comment 7 WebKit Review Bot 2012-01-18 23:40:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2012-01-19 15:57:50 PST
Comment on attachment 123064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123064&action=review

> Source/WebCore/dom/Node.cpp:132
> +static bool isValidNameStartCharacter(UChar c)

We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions?
Comment 9 Adam Barth 2012-01-19 16:01:28 PST
> We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions?

Sure.  Should we move the functions to QualifiedName.cpp at the same time?  That seems like a more natural place for them to live.
Comment 10 Adam Barth 2012-01-19 16:02:37 PST
I filed Bug 76672 on this topic.