Bug 76589 - Assigning to Element.prefix should throw exception when using illegal characters
: Assigning to Element.prefix should throw exception when using illegal characters
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 76198
  Show dependency treegraph
 
Reported: 2012-01-18 17:09 PST by
Modified: 2012-01-19 16:02 PST (History)


Attachments
Patch (6.05 KB, patch)
2012-01-18 17:12 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
Patch (7.02 KB, patch)
2012-01-18 21:07 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2012-01-18 21:26 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-01-18 17:09:50 PST
Assigning to Element.prefix should throw exception when using illegal characters
------- Comment #1 From 2012-01-18 17:12:21 PST -------
Created an attachment (id=123041) [details]
Patch
------- Comment #2 From 2012-01-18 17:28:12 PST -------
(From update of attachment 123041 [details])
Um... I think we need at least 10x this many tests for this much code. :(
------- Comment #3 From 2012-01-18 17:35:05 PST -------
(From update of attachment 123041 [details])
ok.
------- Comment #4 From 2012-01-18 21:07:15 PST -------
Created an attachment (id=123064) [details]
Patch
------- Comment #5 From 2012-01-18 21:26:29 PST -------
Created an attachment (id=123068) [details]
Patch
------- Comment #6 From 2012-01-18 23:39:56 PST -------
(From update of attachment 123068 [details])
Clearing flags on attachment: 123068

Committed r105388: <http://trac.webkit.org/changeset/105388>
------- Comment #7 From 2012-01-18 23:40:00 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #8 From 2012-01-19 15:57:50 PST -------
(From update of attachment 123064 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=123064&action=review

> Source/WebCore/dom/Node.cpp:132
> +static bool isValidNameStartCharacter(UChar c)

We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions?
------- Comment #9 From 2012-01-19 16:01:28 PST -------
> We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions?

Sure.  Should we move the functions to QualifiedName.cpp at the same time?  That seems like a more natural place for them to live.
------- Comment #10 From 2012-01-19 16:02:37 PST -------
I filed Bug 76672 on this topic.