Bug 76672 - Node.cpp shouldn't duplicate QualifiedName parsing logic
Summary: Node.cpp shouldn't duplicate QualifiedName parsing logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 16:02 PST by WebKit Review Bot
Modified: 2012-01-25 15:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2012-01-25 02:52 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (3.53 KB, patch)
2012-01-25 14:37 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-01-19 16:02:11 PST 
Move isValidNameStart and friends to QualifiedName.cpp
Requested by abarth on #webkit.
Comment 1 Adam Barth 2012-01-25 02:52:09 PST 
Created attachment 123906 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-25 05:09:06 PST 
Comment on attachment 123906 [details]
Patch

Rejecting attachment 123906 [details] from commit-queue.

New failing tests:
fast/dom/node-prefix-setter-namespace-exception.html
fast/dom/element-attribute-js-null.html
Full output: http://queues.webkit.org/results/11242763
Comment 3 WebKit Review Bot 2012-01-25 07:13:52 PST 
Comment on attachment 123906 [details]
Patch

Attachment 123906 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11159531

New failing tests:
fast/dom/node-prefix-setter-namespace-exception.html
fast/dom/element-attribute-js-null.html
Comment 4 Adam Barth 2012-01-25 14:37:23 PST 
Created attachment 124014 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-25 15:31:43 PST 
Comment on attachment 124014 [details]
Patch for landing

Clearing flags on attachment: 124014

Committed r105933: <http://trac.webkit.org/changeset/105933>
Comment 6 WebKit Review Bot 2012-01-25 15:31:48 PST 
All reviewed patches have been landed.  Closing bug.