See thread: http://lists.w3.org/Archives/Public/public-webapps/2012JanMar/0141.html and W3C bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=15434 Currently, when following the spec to "set the property in value pointed to by store's key path to the new value for key", WebKit does nothing if intermediate values along the keyPath can't be set, e.g.: var record = {foo: 1}; hypotheticalSetValueViaKeyPathFunction(record, "bar.baz", "newvalue"); WebKit currently doesn't modify record in that case. The spec is being updated so that record would have the new value: record := {foo: 1, bar: { baz: "newvalue" } }
Created attachment 122850 [details] Patch
tony@, can you r? Name suggestions for what I've called "ensure" are appreciated.
(In reply to comment #2) > Name suggestions for what I've called "ensure" are appreciated. ensure seems fine. Maybe "validate" or "verify" as well.
Comment on attachment 122850 [details] Patch Rejecting attachment 122850 [details] from commit-queue. jsbell@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 122850 [details] Patch Clearing flags on attachment: 122850 Committed r105331: <http://trac.webkit.org/changeset/105331>
All reviewed patches have been landed. Closing bug.
Rolled out in r105376 as it broke the Chromium InjectIDBKey browser test.
Rolled patch back in after discussion with jsbell - landed in WebKit r105378