Clean EventContext class. See https://bugs.webkit.org/show_bug.cgi?id=76217#c10 for more info. This should be only refactoring, no functional changes.
Created attachment 122707 [details] clean EventContext
Comment on attachment 122707 [details] clean EventContext View in context: https://bugs.webkit.org/attachment.cgi?id=122707&action=review > Source/WebCore/dom/EventDispatcher.cpp:311 > + const EventContext& eventContext = m_ancestors[i-1]; I think you can do even better here: instead of exposing currentTarget, add a method that checks for equality of target and currentTarget (adjustedTargetSameAsTarget? atTarget?). This way, you aren't exposing unnecessary information from EventContext.
Created attachment 122865 [details] update
Thank you for the review. I've updated the patch. (In reply to comment #2) > (From update of attachment 122707 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122707&action=review > > > Source/WebCore/dom/EventDispatcher.cpp:311 > > + const EventContext& eventContext = m_ancestors[i-1]; > > I think you can do even better here: instead of exposing currentTarget, add a method that checks for equality of target and currentTarget (adjustedTargetSameAsTarget? atTarget?). This way, you aren't exposing unnecessary information from EventContext. I named it EventContext::currentTargetSameAsTarget.
Created attachment 122867 [details] update
Ops. I updated the patch without the previous patch got r+. The new patch fixes one style issue. No behavior change. Could you review it again?
Comment on attachment 122867 [details] update Clearing flags on attachment: 122867 Committed r105241: <http://trac.webkit.org/changeset/105241>
All reviewed patches have been landed. Closing bug.