Bug 76358 - [Refactoring] ShadowRoot should be under html/shadow
Summary: [Refactoring] ShadowRoot should be under html/shadow
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 76241 76353
  Show dependency tree / graph
 
Reported: 2012-01-15 20:45 PST by Hajime Morrita
Modified: 2012-01-17 21:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (43.03 KB, patch)
2012-01-15 22:32 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-01-15 20:45:58 PST 
Because it is a part of HTML shadow DOM spec, this should be under html/shadow.
We have some part of its implementation under dom though, because Element attachment process depends on it.
My plan is to split dom/ShadowRoot to dom/ShadowRootBase and html/ShadowRoot.
Comment 1 Hajime Morrita 2012-01-15 22:32:06 PST 
Created attachment 122594 [details]
Patch
Comment 2 Hajime Morrita 2012-01-15 22:33:07 PST 
Hi Dimitri, could you take a look? I'm going to add an idl against this html/shadow/ShadowRoot.
Comment 3 Dimitri Glazkov (Google) 2012-01-17 19:18:54 PST 
(In reply to comment #0)
> Because it is a part of HTML shadow DOM spec, this should be under html/shadow.
> We have some part of its implementation under dom though, because Element attachment process depends on it.
> My plan is to split dom/ShadowRoot to dom/ShadowRootBase and html/ShadowRoot.

Is this really necessary? I think it's fine to have DOM objects under dom/. There are already plenty of examples. It feels like we're just splitting classes for no good reason.
Comment 4 Hajime Morrita 2012-01-17 21:02:41 PST 
> Is this really necessary? I think it's fine to have DOM objects under dom/. There are already plenty of examples. It feels like we're just splitting classes for no good reason.
I originally worried about layering violation. 
But yes, there are many other classes doing that.
I'm closing this.