Bug 76241 - Move ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass of HTMLElement
Summary: Move ShadowContentElement from dom/ to html/ and make ShadowContentElement su...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 76358
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-12 19:44 PST by Shinya Kawanaka
Modified: 2012-01-18 01:15 PST (History)
9 users (show)

See Also:


Attachments
Build Test (84.52 KB, patch)
2012-01-16 22:21 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Build Test Again (104.87 KB, patch)
2012-01-16 22:51 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Build Test Again (102.84 KB, patch)
2012-01-16 23:24 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Build Test (103.21 KB, patch)
2012-01-16 23:50 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Build Test (115.31 KB, patch)
2012-01-17 00:33 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Build Test (115.17 KB, patch)
2012-01-17 00:45 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (115.72 KB, patch)
2012-01-17 01:37 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (107.12 KB, patch)
2012-01-17 23:38 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-01-12 19:44:47 PST
Moves ShadowContentElement from dom/ to html/
We should take into account to dom shouldn't depend on html.
Comment 1 Hajime Morrita 2012-01-12 20:11:22 PST
Note that ShadowContentElement should become HTMLContentElement,
which should be a subclass of HTMLElement.
Comment 2 Shinya Kawanaka 2012-01-16 22:21:40 PST
Created attachment 122715 [details]
Build Test
Comment 3 Gyuyoung Kim 2012-01-16 22:26:03 PST
Comment on attachment 122715 [details]
Build Test

Attachment 122715 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11267065
Comment 4 Early Warning System Bot 2012-01-16 22:35:42 PST
Comment on attachment 122715 [details]
Build Test

Attachment 122715 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11111078
Comment 5 Shinya Kawanaka 2012-01-16 22:51:35 PST
Created attachment 122716 [details]
Build Test Again
Comment 6 Shinya Kawanaka 2012-01-16 23:24:32 PST
Created attachment 122717 [details]
Build Test Again
Comment 7 Shinya Kawanaka 2012-01-16 23:50:53 PST
Created attachment 122720 [details]
Build Test
Comment 8 Collabora GTK+ EWS bot 2012-01-17 00:04:41 PST
Comment on attachment 122720 [details]
Build Test

Attachment 122720 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11262092
Comment 9 Shinya Kawanaka 2012-01-17 00:33:26 PST
Created attachment 122726 [details]
Build Test
Comment 10 Gyuyoung Kim 2012-01-17 00:42:41 PST
Comment on attachment 122726 [details]
Build Test

Attachment 122726 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11269121
Comment 11 Shinya Kawanaka 2012-01-17 00:45:12 PST
Created attachment 122729 [details]
Build Test
Comment 12 Shinya Kawanaka 2012-01-17 01:37:06 PST
Created attachment 122735 [details]
Patch
Comment 13 Dimitri Glazkov (Google) 2012-01-17 09:29:18 PST
Comment on attachment 122735 [details]
Patch

make sure Safari/Mac builds before landing.
Comment 14 Shinya Kawanaka 2012-01-17 23:38:38 PST
Created attachment 122879 [details]
Patch for landing
Comment 15 Shinya Kawanaka 2012-01-17 23:39:54 PST
(In reply to comment #13)
> (From update of attachment 122735 [details])
> make sure Safari/Mac builds before landing.

Thank you for reviewing. I've confirmed it builds on Snow Leopard Mac in my environment.
Comment 16 WebKit Review Bot 2012-01-18 01:15:41 PST
Comment on attachment 122879 [details]
Patch for landing

Clearing flags on attachment: 122879

Committed r105249: <http://trac.webkit.org/changeset/105249>
Comment 17 WebKit Review Bot 2012-01-18 01:15:48 PST
All reviewed patches have been landed.  Closing bug.