Bug 76350 - ScriptRunner should also keep references to pending async scripts
Summary: ScriptRunner should also keep references to pending async scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 76083
  Show dependency treegraph
 
Reported: 2012-01-15 14:40 PST by jochen
Modified: 2012-01-16 01:37 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.22 KB, patch)
2012-01-15 14:43 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (8.07 KB, patch)
2012-01-15 14:58 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (8.96 KB, patch)
2012-01-16 01:20 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-01-15 14:40:26 PST
ScriptRunner should also keep references to pending async scripts
Comment 1 jochen 2012-01-15 14:43:39 PST
Created attachment 122574 [details]
Patch
Comment 2 jochen 2012-01-15 14:58:52 PST
Created attachment 122575 [details]
Patch
Comment 3 Adam Barth 2012-01-15 15:00:16 PST
Comment on attachment 122575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122575&action=review

> Source/WebCore/dom/ScriptElement.cpp:236
> +        m_element->document()->scriptRunner()->queueScriptForExecution(this, m_cachedScript, ScriptRunner::ASYNC_EXECUTION);

These enum values shouldn't be in ALL_CAPS, but that's a pre-existing problem.

> Source/WebCore/dom/ScriptRunner.cpp:102
> +    default:
> +        ASSERT_NOT_REACHED();

In WebKit, we leave off the default cases for enums so the compiler can complain when we forget one.
Comment 4 Csaba Osztrogonác 2012-01-16 00:48:58 PST
I skipped the failing test on Qt: http://trac.webkit.org/changeset/105038 to make the bot green. Please unskip it when you land the proper fix.
Comment 5 jochen 2012-01-16 01:20:34 PST
Created attachment 122603 [details]
Patch
Comment 6 WebKit Review Bot 2012-01-16 01:37:18 PST
Comment on attachment 122603 [details]
Patch

Clearing flags on attachment: 122603

Committed r105041: <http://trac.webkit.org/changeset/105041>
Comment 7 WebKit Review Bot 2012-01-16 01:37:23 PST
All reviewed patches have been landed.  Closing bug.