ScriptRunner should also keep references to pending async scripts
Created attachment 122574 [details] Patch
Created attachment 122575 [details] Patch
Comment on attachment 122575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122575&action=review > Source/WebCore/dom/ScriptElement.cpp:236 > + m_element->document()->scriptRunner()->queueScriptForExecution(this, m_cachedScript, ScriptRunner::ASYNC_EXECUTION); These enum values shouldn't be in ALL_CAPS, but that's a pre-existing problem. > Source/WebCore/dom/ScriptRunner.cpp:102 > + default: > + ASSERT_NOT_REACHED(); In WebKit, we leave off the default cases for enums so the compiler can complain when we forget one.
I skipped the failing test on Qt: http://trac.webkit.org/changeset/105038 to make the bot green. Please unskip it when you land the proper fix.
Created attachment 122603 [details] Patch
Comment on attachment 122603 [details] Patch Clearing flags on attachment: 122603 Committed r105041: <http://trac.webkit.org/changeset/105041>
All reviewed patches have been landed. Closing bug.