Bug 76083 – Fail to run non-async scripts in IETC 11_RemovingAsyncScript

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

Fail to run non-async scripts in IETC 11_RemovingAsyncScript

http://samples.msdn.microsoft.com/ietestcenter/HTML5/show_async_test.htm?11_RemovingAsyncScript

We only show "4".  Unclear why we don't run 1 2 or 3.

[Eric Seidel (no email)]

I suspect this will be simple to track down in a debugger.  I didn't spend very long looking at the reduction.

[James Simonsen]

Actually, Jochen has already started on this. So I'll pass this bug to him.

Created attachment 122331 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 122331 [details]
Patch

ick.  Really?  We need PHP for this?

Looks fine though.

[James Simonsen]

View in context: https://bugs.webkit.org/attachment.cgi?id=122331&action=review

> Source/WebCore/dom/ScriptElement.cpp:85
> +    if (!m_willExecuteInOrder)

Hmm. I can't find anything in the spec for this. It seems like once we reach the end of prepareScript(), we need to execute it, unless it's parser-inserted and no longer in the document. That means we were broken in the async=true case too. The correct fix is probably to remove this function entirely.

http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#execute-the-script-block

Can you try running the tests without this? If none break, we should remove it. If one does, we should add a FIXME that this is non-standard.

> LayoutTests/http/tests/misc/async-script-expected.txt:1
> +Test that a synchronous script tag is executed in the right order, even if it's removed from the document after before it was loaded.

"after before"?

Created attachment 122386 [details]
Patch

[Adam Barth]

Comment on attachment 122386 [details]
Patch

Did you want to add a test for the async=true case as well?

Created attachment 122393 [details]
Patch

[Adam Barth]

Comment on attachment 122393 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 122393 [details]
Patch

Attachment 122393 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11142945

New failing tests:
http/tests/misc/async-script.html

Created attachment 122405 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 122405 [details]
Patch

LGTM.

[Tony Gentilcore]

LGTM, nice

[WebKit Review Bot]

Comment on attachment 122405 [details]
Patch

Clearing flags on attachment: 122405

Committed r104927: <http://trac.webkit.org/changeset/104927>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because it fails on SL and Qt:
--- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/misc/async-script-expected.txt 
+++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/misc/async-script-actual.txt 
@@ -1,5 +1,6 @@
+FAIL: Timed out waiting for notifyDone to be called
 Test that an asynchronous script tag is executed, even if it's removed from the document before it was loaded.
 
 This test passes if the word "PASS" is displayed below.
 
-PASS
+


Could you check what the problem is?

(In reply to comment #16)
> Reopen, because it fails on SL and Qt:
> --- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/misc/async-script-expected.txt 
> +++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/misc/async-script-actual.txt 
> @@ -1,5 +1,6 @@
> +FAIL: Timed out waiting for notifyDone to be called
>  Test that an asynchronous script tag is executed, even if it's removed from the document before it was loaded.
> 
>  This test passes if the word "PASS" is displayed below.
> 
> -PASS
> +
> 
> 
> Could you check what the problem is?

looking..

posted a fix in bug 76350

[Alexey Proskuryakov]

*** Bug 84884 has been marked as a duplicate of this bug. ***