Bug 76341 - [Qt] Enable -Werror on Mac OS X builds
Summary: [Qt] Enable -Werror on Mac OS X builds
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.7
: P2 Normal
Assignee: Alexander Færøy
URL:
Keywords: Qt, QtTriaged
Depends on: 76340
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-14 13:13 PST by Alexander Færøy
Modified: 2014-02-03 03:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2012-01-14 13:15 PST, Alexander Færøy 		hausmann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2012-01-14 13:13:01 PST 
SSIA.
Comment 1 Alexander Færøy 2012-01-14 13:15:05 PST 
Created attachment 122557 [details]
Patch
Comment 2 Alexander Færøy 2012-01-14 13:15:32 PST 
Adding Tor Arne for review.
Comment 3 Antonio Gomes 2012-01-14 19:15:18 PST 
Comment on attachment 122557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122557&action=review

> Tools/ChangeLog:1
> +2012-01-14  Alexander Færøy  <alexander.faeroy@nokia.com>

that did not work
Comment 4 Alexander Færøy 2012-01-14 19:17:00 PST 
(In reply to comment #3)
> that did not work

So far, all my patches has looked like that in the review tool, but they look fine when they are commited. 

The curse of having dodgy letters in the surname :-(
Comment 5 Simon Hausmann 2012-01-16 00:38:30 PST 
Comment on attachment 122557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122557&action=review

>> Tools/ChangeLog:1
>> +2012-01-14  Alexander Færøy  <alexander.faeroy@nokia.com>
> 
> that did not work

Actually it's correct. It's just that in bugzilla it's not shown correctly, but when landing the utf-8 encoding is preserved correctly.
Comment 6 Tor Arne Vestbø 2012-01-16 04:37:01 PST 
(In reply to comment #1)
> Created an attachment (id=122557) [details]
> Patch

Do you have a bug tracking the warnings that are left to fix before we land this?
Comment 7 Csaba Osztrogonác 2012-04-17 05:53:58 PDT 
Why didn't you guys land it? Is there any warning now on Mac?
Comment 8 Alexander Færøy 2012-04-17 09:28:47 PDT 
There are still some warnings that needs to get fixed before this can be landed.
Comment 9 Eric Seidel (no email) 2013-01-04 02:20:08 PST 
Are those warnings tracked?  Should this be resolved "LATER" and fixed once those are?
Comment 10 Jocelyn Turcotte 2014-02-03 03:19:37 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.