Bug 76176 - Web Inspector: [Chomium] Resources loaded with 304 status code have receiving time of 15000 days in network panel.
Summary: Web Inspector: [Chomium] Resources loaded with 304 status code have receiving...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: James Simonsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 07:25 PST by Vsevolod Vlasov
Modified: 2012-01-13 03:23 PST (History)
14 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2012-01-12 15:56 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-01-12 07:25:17 PST 
All resources with 304 status code have receiving time set to 15000.
This can be easily reproduced by loading some site (e.g. cnn.com) and pressing f5 to reload.

This was caused by http://trac.webkit.org/changeset/102961 (https://bugs.webkit.org/show_bug.cgi?id=58354).

Switching from currentTime() to monotonicallyIncreasingTime() in SubresourceLoader (see link below) fixes it, but I am not sure it won't break things on other platforms.
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/loader/SubresourceLoader.cpp&exact_package=chromium&q=subresourceloader&type=cs&l=164

simonjam@, could you please have a look on that?
Comment 1 James Simonsen 2012-01-12 13:58:23 PST 
Yep, that's the right fix. I'll upload a patch shortly.
Comment 2 James Simonsen 2012-01-12 15:56:20 PST 
Created attachment 122328 [details]
Patch
Comment 3 James Simonsen 2012-01-12 16:01:11 PST 
Nate, it looks like you fixed revalidation shortly before I switched everything to monotonic time, and I missed your change. This should fix it to use monotonic time like the rest of resource loading. Would you mind reviewing it?
Comment 4 WebKit Review Bot 2012-01-12 17:57:12 PST 
Comment on attachment 122328 [details]
Patch

Clearing flags on attachment: 122328

Committed r104887: <http://trac.webkit.org/changeset/104887>
Comment 5 WebKit Review Bot 2012-01-12 17:57:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Vsevolod Vlasov 2012-01-13 03:23:32 PST 
FYI: I filed http://code.google.com/p/chromium/issues/detail?id=110154 to merge it to Chromium M17.