Bug 76036 – Implement the [Supplemental] IDL for custom methods

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

We have implemented the [Supplemental] IDL for non-custom methods in bug 75944. We should also implement it for custom methods.

By this fix, we will have implemented the [Supplemental] IDL for custom attributes, non-custom attributes, custom methods and non-custom methods, which will cover most practical use cases.

[Kentaro Hara]

Created attachment 122001 [details]
Patch

[Kentaro Hara]

Comment on attachment 122001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122001&action=review

> Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h:48
> +- (void)supplementalMethod3;

Currently ObjC does not support custom attributes nor methods, but ObjC outputs meaningless code for them. I'll stop those outputs in a follow-up patch.

[Adam Barth]

Comment on attachment 122001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122001&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:332
> +    TestInterface* impl = static_cast<TestInterface*>(castedThis->impl());
> +    return JSValue::encode(castedThis->supplementalMethod3(impl, exec));

I'm not sure I understand.  This looks like we're calling a non-static method of JSTestInterface, which means we don't need to passing impl as an argument because JSTestInterface already knows about impl.

[Kentaro Hara]

Created attachment 122111 [details]
Patch

[Kentaro Hara]

Comment on attachment 122001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122001&action=review

>> Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:332
>> +    return JSValue::encode(castedThis->supplementalMethod3(impl, exec));
> 
> I'm not sure I understand.  This looks like we're calling a non-static method of JSTestInterface, which means we don't need to passing impl as an argument because JSTestInterface already knows about impl.

Right. Fixed it. I've made a similar mistake in bug 74837 and bug 74841. I'll fix them in the next patch.

[WebKit Review Bot]

Comment on attachment 122111 [details]
Patch

Clearing flags on attachment: 122111

Committed r104767: <http://trac.webkit.org/changeset/104767>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.