Bug 75944 – Support the [Supplemental] IDL on methods

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

Currently the [Supplemental] IDL is supported on attributes but not supported on methods. We should support it.

interface [Supplemental=XXXX]
YYYY {
    attribute int a;  // Supported
    void f();  // Not supported
}

[Kentaro Hara]

Created attachment 121811 [details]
Patch

[WebKit Review Bot]

Attachment 121811 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:80:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:85:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

I thought this was already working:

http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/intents/NavigatorIntents.idl#L26
http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/intents/NavigatorIntents.cpp#L52

[Kentaro Hara]

Committed r104643: <http://trac.webkit.org/changeset/104643>

[Kentaro Hara]

Comment on attachment 121811 [details]
Patch

Committed manually to avoid style check error. Thanks.