Ever since r104174, 500+ tests have been failing on Windows. Here's an example test run: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r104486%20(19677)/results.html My guess is that the scale factor is not getting reset between tests or something.
<rdar://problem/10669185>
Mac DRT does a few things to reset zooming/scaling between each test: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm?rev=104360#L1202 Win DRT doesn't do all the same things: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp?rev=104360#L900
(In reply to comment #2) > Mac DRT does a few things to reset zooming/scaling between each test: > > http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm?rev=104360#L1202 > > Win DRT doesn't do all the same things: > > http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp?rev=104360#L900 Sorry, I didn't realize this was needed. I didn't see the issue on chromium platforms. I don't have access to a Mac at the moment to do some testing but I can look into this later tonight, if you don't have the cycles to fix it/investigate it yourself.
Any update on this?
Created attachment 280591 [details] Patch
Comment on attachment 280591 [details] Patch Are you planning to update expectations after landing this?
(In reply to comment #6) > Comment on attachment 280591 [details] > Patch > > Are you planning to update expectations after landing this? Yes, I had planned to update expectations, but I couldn't find any skipped page scale tests. I will have a second look. Thanks for reviewing!
Committed r201720: <https://trac.webkit.org/changeset/201720>