Bug 64512 – Move scalePageBy from eventSender to window.internals

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

eventSender doesn't seem like the right place form scalePageBy(). It should move to window.internal now.

[Fady Samuel]

I'd like to do this for setting fixed layout as well.

There's a bunch of layout tests that need changing, and then a lot of platform-specific code that needs to be removed. I'll add a copy of scalePageBy to window.internals, and then we can delete platform specific code as a separate patch or let each port deal with that on their own.

[Fady Samuel]

Created attachment 117708 [details]
Patch

[Fady Samuel]

I've restricted the scope of this patch to just setPageScaleFactor. I will add deviceScaleFactor and and fixed layout in a subsequent bug report.

[Collabora GTK+ EWS bot]

Comment on attachment 117708 [details]
Patch

Attachment 117708 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10725675

[Fady Samuel]

Created attachment 117745 [details]
Patch

[Collabora GTK+ EWS bot]

Comment on attachment 117745 [details]
Patch

Attachment 117745 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10732247

[Fady Samuel]

Created attachment 117758 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 117758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117758&action=review

> Source/WebCore/testing/Internals.idl:83
> +        float getPageScaleFactor(in Document document) raises(DOMException);

We don't normally use 'get' in getters.

[Fady Samuel]

Created attachment 118269 [details]
Patch

[Fady Samuel]

(In reply to comment #8)
> (From update of attachment 117758 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117758&action=review
> 
> > Source/WebCore/testing/Internals.idl:83
> > +        float getPageScaleFactor(in Document document) raises(DOMException);
> 
> We don't normally use 'get' in getters.

Fixed, submitted a patch to get the updated symbols from the various EWS bots, then will land.

[Fady Samuel]

Created attachment 118341 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 118341 [details]
Patch for landing

Clearing flags on attachment: 118341

Committed r102323: <http://trac.webkit.org/changeset/102323>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

*** Bug 59098 has been marked as a duplicate of this bug. ***

[Fady Samuel]

Attempting to reland this (I don' believe this broke the build given the green EWS) If things break, I'm around to figure out what the problem is.

[Fady Samuel]

This should land, I'm not sure if it broke anything? Checking again now.

[Fady Samuel]

Created attachment 121282 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 121282 [details]
Patch for landing

Clearing flags on attachment: 121282

Committed r104174: <http://trac.webkit.org/changeset/104174>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

This seems to have caused bug 75965.