Bug 64512 - Move scalePageBy from eventSender to window.internals
Summary: Move scalePageBy from eventSender to window.internals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
: 59098 (view as bug list)
Depends on: 74069
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-13 22:45 PDT by Simon Fraser (smfr)
Modified: 2016-06-06 14:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (29.46 KB, patch)
2011-12-02 15:49 PST, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch (31.52 KB, patch)
2011-12-02 23:31 PST, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch (32.80 KB, patch)
2011-12-03 07:55 PST, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch (32.97 KB, patch)
2011-12-07 13:46 PST, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch for landing (32.87 KB, patch)
2011-12-08 00:02 PST, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch for landing (33.01 KB, patch)
2012-01-05 08:27 PST, Fady Samuel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-07-13 22:45:58 PDT
eventSender doesn't seem like the right place form scalePageBy(). It should move to window.internal now.
Comment 1 Fady Samuel 2011-12-02 08:45:31 PST
I'd like to do this for setting fixed layout as well.

There's a bunch of layout tests that need changing, and then a lot of platform-specific code that needs to be removed. I'll add a copy of scalePageBy to window.internals, and then we can delete platform specific code as a separate patch or let each port deal with that on their own.
Comment 2 Fady Samuel 2011-12-02 15:49:18 PST
Created attachment 117708 [details]
Patch
Comment 3 Fady Samuel 2011-12-02 15:50:24 PST
I've restricted the scope of this patch to just setPageScaleFactor. I will add deviceScaleFactor and and fixed layout in a subsequent bug report.
Comment 4 Collabora GTK+ EWS bot 2011-12-02 22:25:01 PST
Comment on attachment 117708 [details]
Patch

Attachment 117708 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10725675
Comment 5 Fady Samuel 2011-12-02 23:31:51 PST
Created attachment 117745 [details]
Patch
Comment 6 Collabora GTK+ EWS bot 2011-12-03 03:16:18 PST
Comment on attachment 117745 [details]
Patch

Attachment 117745 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10732247
Comment 7 Fady Samuel 2011-12-03 07:55:32 PST
Created attachment 117758 [details]
Patch
Comment 8 Simon Fraser (smfr) 2011-12-07 12:10:17 PST
Comment on attachment 117758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117758&action=review

> Source/WebCore/testing/Internals.idl:83
> +        float getPageScaleFactor(in Document document) raises(DOMException);

We don't normally use 'get' in getters.
Comment 9 Fady Samuel 2011-12-07 13:46:19 PST
Created attachment 118269 [details]
Patch
Comment 10 Fady Samuel 2011-12-07 13:47:36 PST
(In reply to comment #8)
> (From update of attachment 117758 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117758&action=review
> 
> > Source/WebCore/testing/Internals.idl:83
> > +        float getPageScaleFactor(in Document document) raises(DOMException);
> 
> We don't normally use 'get' in getters.

Fixed, submitted a patch to get the updated symbols from the various EWS bots, then will land.
Comment 11 Fady Samuel 2011-12-08 00:02:40 PST
Created attachment 118341 [details]
Patch for landing
Comment 12 WebKit Review Bot 2011-12-08 01:18:19 PST
Comment on attachment 118341 [details]
Patch for landing

Clearing flags on attachment: 118341

Committed r102323: <http://trac.webkit.org/changeset/102323>
Comment 13 WebKit Review Bot 2011-12-08 01:18:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 Adam Roben (:aroben) 2011-12-08 06:44:43 PST
*** Bug 59098 has been marked as a duplicate of this bug. ***
Comment 15 Fady Samuel 2011-12-08 08:49:34 PST
Attempting to reland this (I don' believe this broke the build given the green EWS) If things break, I'm around to figure out what the problem is.
Comment 16 Fady Samuel 2012-01-05 08:16:25 PST
This should land, I'm not sure if it broke anything? Checking again now.
Comment 17 Fady Samuel 2012-01-05 08:27:20 PST
Created attachment 121282 [details]
Patch for landing
Comment 18 WebKit Review Bot 2012-01-05 10:17:03 PST
Comment on attachment 121282 [details]
Patch for landing

Clearing flags on attachment: 121282

Committed r104174: <http://trac.webkit.org/changeset/104174>
Comment 19 WebKit Review Bot 2012-01-05 10:17:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 20 Adam Roben (:aroben) 2012-01-10 08:12:56 PST
This seems to have caused bug 75965.