Bug 75787 - Layout Test fast/text/international/spaces-combined-in-vertical-text.html is failing
Summary: Layout Test fast/text/international/spaces-combined-in-vertical-text.html is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ken Buchanan
URL:
Keywords:
: 75752 75833 76554 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-07 16:01 PST by Dmitry Lomov
Modified: 2012-01-19 10:05 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2012-01-19 07:54 PST, Ken Buchanan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2012-01-07 16:01:43 PST 
The following layout test is failing (timing out) on chromium-linux, chromium-mac

fast/text/international/spaces-combined-in-vertical-text.html

Probable cause:

http://trac.webkit.org/changeset/104322.
Comment 1 Abhishek Arya 2012-01-08 21:30:38 PST 
Did anyone rollout his patch or landed a test expectations update ?? Are you sure it is his patch, because cq landed it and chrome bots look green.

Me and him are both on vacation this week. Ken, should take a look at this early next week.
Comment 2 Alexey Proskuryakov 2012-01-09 10:50:34 PST 
*** Bug 75833 has been marked as a duplicate of this bug. ***
Comment 3 Alexey Proskuryakov 2012-01-09 10:51:04 PST 
*** Bug 75752 has been marked as a duplicate of this bug. ***
Comment 4 Ken Buchanan 2012-01-19 07:54:44 PST 
Created attachment 123129 [details]
Patch
Comment 5 Ken Buchanan 2012-01-19 07:58:36 PST 
The test is the one that I added in r104322, but the problem is that in the patch I was sloppy with handling loop iteration in skipLeadingWhitespace.

I think the fix is fairly straightforward.

ap do you care to review?
Comment 6 Simon Fraser (smfr) 2012-01-19 08:30:23 PST 
*** Bug 76554 has been marked as a duplicate of this bug. ***
Comment 7 Ken Buchanan 2012-01-19 08:45:23 PST 
smfr can you review this? I don't know that I need to be picky about the reviewer, it's just a logic fix to prevent getting stuck in that loop.
Comment 8 WebKit Review Bot 2012-01-19 10:05:48 PST 
Comment on attachment 123129 [details]
Patch

Clearing flags on attachment: 123129

Committed r105423: <http://trac.webkit.org/changeset/105423>
Comment 9 WebKit Review Bot 2012-01-19 10:05:53 PST 
All reviewed patches have been landed.  Closing bug.