Bug 75697 - DOMWindow should be a FrameDestructionObserver
Summary: DOMWindow should be a FrameDestructionObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 75693
Blocks: 75699
  Show dependency treegraph
 
Reported: 2012-01-06 02:50 PST by Adam Barth
Modified: 2012-01-07 00:12 PST (History)
6 users (show)

See Also:


Attachments
Patch (5.97 KB, patch)
2012-01-06 02:51 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (6.24 KB, patch)
2012-01-06 02:53 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (5.93 KB, patch)
2012-01-06 16:11 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-01-06 02:50:16 PST
DOMWindow should be a FrameDestructionObserver
Comment 1 Adam Barth 2012-01-06 02:51:42 PST
Created attachment 121417 [details]
Patch
Comment 2 Adam Barth 2012-01-06 02:52:12 PST
This is going to fail to compile until Bug 75693 lands.
Comment 3 Adam Barth 2012-01-06 02:53:47 PST
Created attachment 121419 [details]
Patch
Comment 4 Early Warning System Bot 2012-01-06 03:06:38 PST
Comment on attachment 121419 [details]
Patch

Attachment 121419 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11147355
Comment 5 WebKit Review Bot 2012-01-06 03:07:53 PST
Comment on attachment 121419 [details]
Patch

Attachment 121419 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11146294
Comment 6 Gyuyoung Kim 2012-01-06 03:10:55 PST
Comment on attachment 121419 [details]
Patch

Attachment 121419 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11144309
Comment 7 Gustavo Noronha (kov) 2012-01-06 04:28:03 PST
Comment on attachment 121419 [details]
Patch

Attachment 121419 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11147376
Comment 8 Alexey Proskuryakov 2012-01-06 10:36:39 PST
Comment on attachment 121419 [details]
Patch

r=me assuming it builds and passes tests.
Comment 9 Adam Barth 2012-01-06 16:11:01 PST
Created attachment 121516 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-01-06 19:12:18 PST
Comment on attachment 121516 [details]
Patch for landing

Clearing flags on attachment: 121516

Committed r104372: <http://trac.webkit.org/changeset/104372>
Comment 11 WebKit Review Bot 2012-01-06 19:12:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Darin Adler 2012-01-07 00:01:14 PST
Seems DOMWindow could have privately derived from FrameDestructionObserver rather than publicly.
Comment 13 Adam Barth 2012-01-07 00:05:05 PST
Comment on attachment 121516 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=121516&action=review

> Source/WebCore/page/DOMWindow.h:-93
> -        Frame* frame() const { return m_frame; }

This method now gets inherited from FrameDestructionObserver and needs to be public.
Comment 14 Darin Adler 2012-01-07 00:12:35 PST
Comment on attachment 121516 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=121516&action=review

>> Source/WebCore/page/DOMWindow.h:-93
>> -        Frame* frame() const { return m_frame; }
> 
> This method now gets inherited from FrameDestructionObserver and needs to be public.

The way to do that and keep the rest of FrameDestructionObserver private is to write:

    using FrameDestructionObserver::frame;